Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Side by Side Diff: src/x64/debug-x64.cc

Issue 137443004: Use kRegisterSize when passing arguments to the C++ runtime for X64 (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comment Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 146 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 __ pop(kScratchRegister); 157 __ pop(kScratchRegister);
158 __ SmiToInteger32(kScratchRegister, kScratchRegister); 158 __ SmiToInteger32(kScratchRegister, kScratchRegister);
159 __ lea(rsp, Operand(rsp, kScratchRegister, times_pointer_size, 0)); 159 __ lea(rsp, Operand(rsp, kScratchRegister, times_pointer_size, 0));
160 160
161 // Get rid of the internal frame. 161 // Get rid of the internal frame.
162 } 162 }
163 163
164 // If this call did not replace a call but patched other code then there will 164 // If this call did not replace a call but patched other code then there will
165 // be an unwanted return address left on the stack. Here we get rid of that. 165 // be an unwanted return address left on the stack. Here we get rid of that.
166 if (convert_call_to_jmp) { 166 if (convert_call_to_jmp) {
167 __ addq(rsp, Immediate(kPointerSize)); 167 __ addq(rsp, Immediate(kPCOnStackSize));
168 } 168 }
169 169
170 // Now that the break point has been handled, resume normal execution by 170 // Now that the break point has been handled, resume normal execution by
171 // jumping to the target address intended by the caller and that was 171 // jumping to the target address intended by the caller and that was
172 // overwritten by the address of DebugBreakXXX. 172 // overwritten by the address of DebugBreakXXX.
173 ExternalReference after_break_target = 173 ExternalReference after_break_target =
174 ExternalReference(Debug_Address::AfterBreakTarget(), masm->isolate()); 174 ExternalReference(Debug_Address::AfterBreakTarget(), masm->isolate());
175 __ Move(kScratchRegister, after_break_target); 175 __ Move(kScratchRegister, after_break_target);
176 __ jmp(Operand(kScratchRegister, 0)); 176 __ jmp(Operand(kScratchRegister, 0));
177 } 177 }
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
342 342
343 const bool Debug::kFrameDropperSupported = true; 343 const bool Debug::kFrameDropperSupported = true;
344 344
345 #undef __ 345 #undef __
346 346
347 #endif // ENABLE_DEBUGGER_SUPPORT 347 #endif // ENABLE_DEBUGGER_SUPPORT
348 348
349 } } // namespace v8::internal 349 } } // namespace v8::internal
350 350
351 #endif // V8_TARGET_ARCH_X64 351 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/x64/code-stubs-x64.cc ('k') | src/x64/deoptimizer-x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698