Issue 1374383003: Ignore Polymer bound src="[[attr]]" from grit processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1374383003: Ignore Polymer bound src="[[attr]]" from grit processing. (Closed)

Created:
5 years, 2 months ago by Dan Beam

Modified:
5 years, 2 months ago

Reviewers:
flackr, esprehn

CC:
grit-developer_googlegroups.com

Base URL:
https://chromium.googlesource.com/external/grit-i18n.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Ignore Polymer bound src="[[attr]]" from grit processing. R=esprehn@chromium.org BUG=526577

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	grit/format/html_inline.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
	M	grit/format/html_inline_unittest.py	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 6 (1 generated)

esprehn

Do you also want to exclude { bindings? I'll admit I don't totally understand how ...

5 years, 2 months ago (2015-10-01 02:21:02 UTC) #2

Dan Beam

On 2015/10/01 02:21:02, esprehn wrote: > Do you also want to exclude { bindings? I'll ...

5 years, 2 months ago (2015-10-01 05:53:57 UTC) #3

Dan Beam

5 years, 2 months ago (2015-10-01 17:55:51 UTC) #6

On 2015/10/01 17:55:05, flackr wrote:
> lgtm, committed revision 199.

w00t! thanks Rob!