grit/format/html_inline.py - Issue 1374383003: Ignore Polymer bound src="[[attr]]" from grit processing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: grit/format/html_inline.py

Issue 1374383003: Ignore Polymer bound src="[[attr]]" from grit processing. (Closed) Base URL: https://chromium.googlesource.com/external/grit-i18n.git@master

Patch Set: test fixes Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: grit/format/html_inline.py

diff --git a/grit/format/html_inline.py b/grit/format/html_inline.py

index bb8416d5c04bdaea427de86365cdfdd394bb9aec..f5324960c7051175d9cf7b089279a810bcf0f887 100755

--- a/grit/format/html_inline.py

+++ b/grit/format/html_inline.py

@@ -46,7 +46,7 @@ _INCLUDE_RE = lazy_re.compile(

'<include[^>]+?src="(?P<filename>[^"\']*)".*?>(\s*</include>)?',

re.DOTALL)

_SRC_RE = lazy_re.compile(

- r'<(?!script)(?:[^>]+?\s)src=(?P<quote>")(?P<filename>[^"\']*)\1',

+ r'<(?!script)(?:[^>]+?\s)src=(?P<quote>")(?!\[\[|{{)(?P<filename>[^"\']*)\1',

re.MULTILINE)

_ICON_RE = lazy_re.compile(

r'<link rel="icon"\s(?:[^>]+?\s)?'

« no previous file with comments | « no previous file | grit/format/html_inline_unittest.py » ('j') | no next file with comments »