Source/web/WebHelperPluginImpl.cpp - Issue 137433008: Have HTMLCollection::item() return an Element as per specification

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebHelperPluginImpl.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebHelperPluginImpl.cpp

diff --git a/Source/web/WebHelperPluginImpl.cpp b/Source/web/WebHelperPluginImpl.cpp

index 9bbf17968ff4fe052a976d2508af312f476f1194..8d5474a01bb39380e9c85652eabae5885a0971f2 100644

--- a/Source/web/WebHelperPluginImpl.cpp

+++ b/Source/web/WebHelperPluginImpl.cpp

@@ -184,9 +184,9 @@ WebPlugin* WebHelperPluginImpl::getPlugin()

ASSERT(objectElements && objectElements->length() == 1);

if (!objectElements || objectElements->length() < 1)

return 0;

- Node* node = objectElements->item(0);

- ASSERT(node->hasTagName(WebCore::HTMLNames::objectTag));

- WebCore::Widget* widget = toHTMLPlugInElement(node)->pluginWidget();

+ Element* element = objectElements->item(0);

+ ASSERT(element->hasTagName(WebCore::HTMLNames::objectTag));

+ WebCore::Widget* widget = toHTMLPlugInElement(element)->pluginWidget();

if (!widget)

return 0;

WebPlugin* plugin = toWebPluginContainerImpl(widget)->plugin();

« no previous file with comments | « Source/web/WebDocument.cpp ('k') | Source/web/WebNodeCollection.cpp » ('j') | no next file with comments »