Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Unified Diff: Source/bindings/v8/V8WindowShell.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebase Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8WindowShell.cpp
diff --git a/Source/bindings/v8/V8WindowShell.cpp b/Source/bindings/v8/V8WindowShell.cpp
index 7b8cdd9db2973657c8d83d164c1060e2481e24c7..6013354c9de185357b3fb25f03d80cf38f7e1540 100644
--- a/Source/bindings/v8/V8WindowShell.cpp
+++ b/Source/bindings/v8/V8WindowShell.cpp
@@ -444,11 +444,11 @@ static v8::Handle<v8::Value> getNamedProperty(HTMLDocument* htmlDocument, const
return v8Undefined();
if (items->hasExactlyOneItem()) {
- Node* node = items->item(0);
+ Element* element = items->item(0);
Frame* frame = 0;
- if (node->hasTagName(HTMLNames::iframeTag) && (frame = toHTMLIFrameElement(node)->contentFrame()))
+ if (element->hasTagName(HTMLNames::iframeTag) && (frame = toHTMLIFrameElement(element)->contentFrame()))
return toV8(frame->domWindow(), creationContext, isolate);
- return toV8(node, creationContext, isolate);
+ return toV8(element, creationContext, isolate);
}
return toV8(items.release(), creationContext, isolate);
}
« no previous file with comments | « no previous file | Source/bindings/v8/custom/V8HTMLAllCollectionCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698