Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2708)

Unified Diff: Source/web/WebNodeCollection.cpp

Issue 137433008: Have HTMLCollection::item() return an Element as per specification (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Additional clean up~ Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/WebHelperPluginImpl.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebNodeCollection.cpp
diff --git a/Source/web/WebNodeCollection.cpp b/Source/web/WebNodeCollection.cpp
index 1715730473d822a39be3283c2f41dc4ee3b24766..719006456952aa1d7cffbddad11d7374a8e89cc1 100644
--- a/Source/web/WebNodeCollection.cpp
+++ b/Source/web/WebNodeCollection.cpp
@@ -74,10 +74,10 @@ unsigned WebNodeCollection::length() const
WebNode WebNodeCollection::nextItem() const
Inactive 2014/02/03 21:33:09 adamk, what do you think about updating nextItem()
{
- Node* node = m_private->item(m_current);
- if (node)
+ Element* element = m_private->item(m_current);
+ if (element)
m_current++;
- return WebNode(node);
+ return WebNode(element);
}
WebNode WebNodeCollection::firstItem() const
« no previous file with comments | « Source/web/WebHelperPluginImpl.cpp ('k') | Source/web/WebPageSerializer.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698