Issue 13743004: FTP: Make ICU resource loading fail loadly (CHECK)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13743004: FTP: Make ICU resource loading fail loadly (CHECK) (Closed)

Created:
7 years, 8 months ago by Paweł Hajdan Jr.

Modified:
7 years, 8 months ago

Reviewers:
eroman, ericroman

CC:
chromium-reviews, cbentzel+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

FTP: Make ICU resource loading fail loadly (CHECK) This way we'll be able to recognize issues like the linked bug faster in the future (user-submitted bug reports are often incomplete, while crash reports are a sure indication of a problem) BUG=177428 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192841

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -0 lines)			Patch
	M	net/ftp/ftp_util.cc	View	1	1 chunk	+18 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ericroman

lgtm https://codereview.chromium.org/13743004/diff/1/net/ftp/ftp_util.cc File net/ftp/ftp_util.cc (right): https://codereview.chromium.org/13743004/diff/1/net/ftp/ftp_util.cc#newcode196 net/ftp/ftp_util.cc:196: CHECK_EQ( 1, map_[ASCIIToUTF16("jan")]); nit: I recommend removing the ...

7 years, 8 months ago (2013-04-06 01:31:41 UTC) #2

Paweł Hajdan Jr.

Committed patchset #2 manually as r192841 (presubmit successful).

7 years, 8 months ago (2013-04-08 18:21:59 UTC) #3

Paweł Hajdan Jr.

7 years, 8 months ago (2013-04-08 18:22:29 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/13743004/diff/1/net/ftp/ftp_util.cc
File net/ftp/ftp_util.cc (right):

https://codereview.chromium.org/13743004/diff/1/net/ftp/ftp_util.cc#newcode196
net/ftp/ftp_util.cc:196: CHECK_EQ( 1, map_[ASCIIToUTF16("jan")]);
On 2013/04/06 01:31:41, ericroman wrote:
> nit: I recommend removing the whitespace on these numbers.

Done.

Expand Messages | Collapse Messages