FTP: Make ICU resource loading fail loadly (CHECK)

net/ftp/ftp_util.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/ftp/ftp_util.h"
 
 #include <map>
 #include <vector>
 
 #include "base/i18n/case_conversion.h"
@@ skipping 169 matching lines @@
         month_name = base::i18n::ToLower(month_name);
 
         map_[month_name] = month + 1;
 
         // Sometimes ICU returns longer strings, but in FTP listings a shorter
         // abbreviation is used (for example for the Russian locale). Make sure
         // we always have a map entry for a three-letter abbreviation.
         map_[month_name.substr(0, 3)] = month + 1;
       }
     }
+
+    // Fail loudly if the data returned by ICU is obviously incomplete.
+    // This is intended to catch cases like http://crbug.com/177428
+    // much earlier. Note that the issue above turned out to be non-trivial
+    // to reproduce - crash data is much better indicator of a problem
+    // than incomplete bug reports.
+    CHECK_EQ( 1, map_[ASCIIToUTF16("jan")]);

[ericroman, 2013/04/06 01:31:41]

nit: I recommend removing the whitespace on these numbers.

[Paweł Hajdan Jr., 2013/04/08 18:22:29]

Done.

+    CHECK_EQ( 2, map_[ASCIIToUTF16("feb")]);
+    CHECK_EQ( 3, map_[ASCIIToUTF16("mar")]);
+    CHECK_EQ( 4, map_[ASCIIToUTF16("apr")]);
+    CHECK_EQ( 5, map_[ASCIIToUTF16("may")]);
+    CHECK_EQ( 6, map_[ASCIIToUTF16("jun")]);
+    CHECK_EQ( 7, map_[ASCIIToUTF16("jul")]);
+    CHECK_EQ( 8, map_[ASCIIToUTF16("aug")]);
+    CHECK_EQ( 9, map_[ASCIIToUTF16("sep")]);
+    CHECK_EQ(10, map_[ASCIIToUTF16("oct")]);
+    CHECK_EQ(11, map_[ASCIIToUTF16("nov")]);
+    CHECK_EQ(12, map_[ASCIIToUTF16("dec")]);
   }
 
   // Maps lowercase month names to numbers in range 1-12.
   std::map<base::string16, int> map_;
 
   DISALLOW_COPY_AND_ASSIGN(AbbreviatedMonthsMap);
 };
 
 }  // namespace
 
@@ skipping 149 matching lines @@
     while (!iter.end() && !u_isspace(iter.get()))
       iter.Advance();
   }
 
   base::string16 result(text.substr(iter.array_pos()));
   TrimWhitespace(result, TRIM_ALL, &result);
   return result;
 }
 
 }  // namespace