Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Unified Diff: chrome/browser/task_management/sampling/task_manager_impl.cc

Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Turn off ResourceReporter on task_management CrOs browser_tests. Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/task_management/sampling/task_manager_impl.cc
diff --git a/chrome/browser/task_management/sampling/task_manager_impl.cc b/chrome/browser/task_management/sampling/task_manager_impl.cc
index cb150dccf9dd21e9f6d090f0f3986abbd32667e6..df38ff3a2fe7794c73e1f1d723863c106b467f32 100644
--- a/chrome/browser/task_management/sampling/task_manager_impl.cc
+++ b/chrome/browser/task_management/sampling/task_manager_impl.cc
@@ -122,10 +122,18 @@ void TaskManagerImpl::GetUSERHandles(TaskId task_id,
#endif // defined(OS_WIN)
}
+bool TaskManagerImpl::IsTaskOnBackgroundedProcess(TaskId task_id) const {
+ return GetTaskGroupByTaskId(task_id)->is_backgrounded();
+}
+
const base::string16& TaskManagerImpl::GetTitle(TaskId task_id) const {
return GetTaskByTaskId(task_id)->title();
}
+const std::string& TaskManagerImpl::GetTaskNameForRappor(TaskId task_id) const {
+ return GetTaskByTaskId(task_id)->rappor_sample_name();
+}
+
base::string16 TaskManagerImpl::GetProfileName(TaskId task_id) const {
return GetTaskByTaskId(task_id)->GetProfileName();
}
@@ -309,6 +317,9 @@ void TaskManagerImpl::Refresh() {
}
void TaskManagerImpl::StartUpdating() {
+ if (is_running_)
+ return;
+
is_running_ = true;
for (auto& provider : task_providers_)
@@ -318,6 +329,9 @@ void TaskManagerImpl::StartUpdating() {
}
void TaskManagerImpl::StopUpdating() {
+ if (!is_running_)
+ return;
+
is_running_ = false;
io_thread_helper_manager_.reset();

Powered by Google App Engine
This is Rietveld 408576698