chrome/browser/task_management/sampling/task_manager_impl.h - Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_management/sampling/task_manager_impl.h

Issue 1374283003: Reporting top cpu and memory consumers via rappor on chromeos (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Turn off ResourceReporter on task_management CrOs browser_tests. Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/task_management/sampling/task_group_sampler.cc ('k') | chrome/browser/task_management/sampling/task_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_management/sampling/task_manager_impl.h

diff --git a/chrome/browser/task_management/sampling/task_manager_impl.h b/chrome/browser/task_management/sampling/task_manager_impl.h

index 89a2ed266c946aeaea191d4a17cf84e205e1320c..e372ac723c8b27b5a9728235cb0f1e6a615a28b4 100644

--- a/chrome/browser/task_management/sampling/task_manager_impl.h

+++ b/chrome/browser/task_management/sampling/task_manager_impl.h

@@ -44,7 +44,9 @@ class TaskManagerImpl :

void GetUSERHandles(TaskId task_id,

int64* current,

int64* peak) const override;

+ bool IsTaskOnBackgroundedProcess(TaskId task_id) const override;

const base::string16& GetTitle(TaskId task_id) const override;

+ const std::string& GetTaskNameForRappor(TaskId task_id) const override;

base::string16 GetProfileName(TaskId task_id) const override;

const gfx::ImageSkia& GetIcon(TaskId task_id) const override;

const base::ProcessHandle& GetProcessHandle(TaskId task_id) const override;