Reporting top cpu and memory consumers via rappor on chromeos

chrome/browser/task_management/task_manager_test_util.h

Index: chrome/browser/task_management/task_manager_test_util.h
diff --git a/chrome/browser/task_management/task_manager_test_util.h b/chrome/browser/task_management/task_manager_test_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..98a9a464cbbcb7c142db7c405aa700bbc4865fee
--- /dev/null
+++ b/chrome/browser/task_management/task_manager_test_util.h
@@ -0,0 +1,77 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_TASK_MANAGEMENT_TASK_MANAGER_TEST_UTIL_H_
+#define CHROME_BROWSER_TASK_MANAGEMENT_TASK_MANAGER_TEST_UTIL_H_

[ncarter (slow), 2015/11/10 23:29:57]

This filename ought to be test_task_manager or fake_task_manager. That will make
it far easier for readers of _unittest.cc to figure out where to look to find
this class.

[afakhry, 2015/11/12 00:21:28]

Done.

+
+#include "base/macros.h"
+#include "base/timer/mock_timer.h"
+#include "chrome/browser/task_management/task_manager_interface.h"
+
+namespace task_management {
+
+// This is a partial stub implementation that can be used as a base class for

[ncarter (slow), 2015/11/10 23:29:57]

What's the guiding principle behind what behavior is stubbed out vs. not? Add
this to the comment.

[afakhry, 2015/11/12 00:21:28]

I'm not sure what you mean. Most of the below functions do nothing or return
invalid values. Subclasses need to only extend the functions they're interested
in to simulate certain behavior.

+// implementations of the task manager used in unit tests.

[ncarter (slow), 2015/11/10 23:29:57]

Ideally this object would be useful without further subclassing. Is that
possible?

[afakhry, 2015/11/12 00:21:28]

Yes it is possible. Subclassing is sometimes needed when certain tests need to
do fake cpu and memory calculations like the case in our ResourceReporterTest.

+class TestTaskManager : public TaskManagerInterface {
+ public:
+  TestTaskManager();
+  ~TestTaskManager() override;
+
+  // task_management::TaskManagerInterface:
+  void ActivateTask(TaskId task_id) override;
+  double GetCpuUsage(TaskId task_id) const override;
+  int64 GetPhysicalMemoryUsage(TaskId task_id) const override;
+  int64 GetPrivateMemoryUsage(TaskId task_id) const override;
+  int64 GetSharedMemoryUsage(TaskId task_id) const override;
+  int64 GetGpuMemoryUsage(TaskId task_id, bool* has_duplicates) const override;
+  int GetIdleWakeupsPerSecond(TaskId task_id) const override;
+  int GetNaClDebugStubPort(TaskId task_id) const override;
+  void GetGDIHandles(TaskId task_id,
+                     int64* current,
+                     int64* peak) const override;
+  void GetUSERHandles(TaskId task_id,
+                      int64* current,
+                      int64* peak) const override;
+  bool IsTaskOnBackgroundedProcess(TaskId task_id) const override;
+  const base::string16& GetTitle(TaskId task_id) const override;
+  const std::string& GetRapporSampleName(TaskId task_id) const override;
+  base::string16 GetProfileName(TaskId task_id) const override;
+  const gfx::ImageSkia& GetIcon(TaskId task_id) const override;
+  const base::ProcessHandle& GetProcessHandle(TaskId task_id) const override;
+  const base::ProcessId& GetProcessId(TaskId task_id) const override;
+  Task::Type GetType(TaskId task_id) const override;
+  int64 GetNetworkUsage(TaskId task_id) const override;
+  int64 GetSqliteMemoryUsed(TaskId task_id) const override;
+  bool GetV8Memory(TaskId task_id,
+                   int64* allocated,
+                   int64* used) const override;
+  bool GetWebCacheStats(
+      TaskId task_id,
+      blink::WebCache::ResourceTypeStats* stats) const override;
+  const TaskIdList& GetTaskIdsList() const override;
+  size_t GetNumberOfTasksOnSameProcess(TaskId task_id) const override;
+
+  base::TimeDelta GetRefreshTime();
+  int64 GetEnabledFlags();
+
+ protected:
+  // task_management::TaskManager:
+  void Refresh() override {}
+  void StartUpdating() override {}
+  void StopUpdating() override {}
+
+  base::ProcessHandle handle_;
+  base::ProcessId pid_;
+  base::string16 title_;
+  std::string rappor_sample_;
+  gfx::ImageSkia icon_;
+  TaskIdList ids_;
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(TestTaskManager);
+};
+
+}  // namespace task_management
+
+#endif  // CHROME_BROWSER_TASK_MANAGEMENT_TASK_MANAGER_TEST_UTIL_H_