Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1373873003: GN: Mark run_findbugs as used in java_library_impl (Closed)

Created:
5 years, 2 months ago by pkotwicz
Modified:
5 years, 2 months ago
Reviewers:
Ian Wen, agrieve
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GN: Mark run_findbugs as used in java_library_impl BUG=536092 TEST=None Committed: https://crrev.com/5e788688d577c0c8c287f42275c0a4f5df291874 Cr-Commit-Position: refs/heads/master@{#351158}

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M build/config/android/internal_rules.gni View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M third_party/gif_player/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 12 (4 generated)
pkotwicz
agrieve@ PTaL
5 years, 2 months ago (2015-09-28 19:59:33 UTC) #2
agrieve
lgtm https://codereview.chromium.org/1373873003/diff/20001/build/config/android/internal_rules.gni File build/config/android/internal_rules.gni (right): https://codereview.chromium.org/1373873003/diff/20001/build/config/android/internal_rules.gni#newcode1188 build/config/android/internal_rules.gni:1188: _run_findbugs = false nit: other ones right above ...
5 years, 2 months ago (2015-09-28 20:17:24 UTC) #3
pkotwicz
ianwen@ for third_party/gif_player
5 years, 2 months ago (2015-09-28 20:21:57 UTC) #4
pkotwicz
ianwen@ for third_party/gif_player
5 years, 2 months ago (2015-09-28 20:23:13 UTC) #6
Ian Wen
Thanks for the quick fix. lgtm
5 years, 2 months ago (2015-09-28 20:30:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373873003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373873003/40001
5 years, 2 months ago (2015-09-28 20:35:03 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-28 21:17:54 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 21:20:19 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/5e788688d577c0c8c287f42275c0a4f5df291874
Cr-Commit-Position: refs/heads/master@{#351158}

Powered by Google App Engine
This is Rietveld 408576698