Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(491)

Unified Diff: build/config/android/internal_rules.gni

Issue 1373873003: GN: Mark run_findbugs as used in java_library_impl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/gif_player/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 00ce47b45ac09a58fac7a62543de01f35c683945..0a8f64dfbf0853e9d70ae4d2a6c10ea31e96314b 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -489,7 +489,9 @@ template("package_apk") {
])
script = "//build/android/gyp/apkbuilder.py"
depfile = "$target_gen_dir/$target_name.d"
- data_deps = [ "//tools/android/md5sum" ] # Used when deploying APKs
+ data_deps = [
+ "//tools/android/md5sum",
+ ] # Used when deploying APKs
inputs = [
invoker.resource_packaged_apk_path,
@@ -1183,6 +1185,8 @@ template("java_library_impl") {
_requires_android =
defined(invoker.requires_android) && invoker.requires_android
assert(_requires_android || true) # Mark as used.
+ _run_findbugs = defined(invoker.run_findbugs) && invoker.run_findbugs
+ assert(_run_findbugs || true) # Mark as used.
if (_supports_android) {
_dex_path = _base_path + ".dex.jar"
@@ -1322,10 +1326,7 @@ template("java_library_impl") {
}
}
- if (defined(invoker.run_findbugs)) {
- run_findbugs = invoker.run_findbugs
- }
- if (run_findbugs) {
+ if (_run_findbugs) {
_final_datadeps += [ ":${_template_name}__findbugs" ]
findbugs("${_template_name}__findbugs") {
build_config = _build_config
« no previous file with comments | « no previous file | third_party/gif_player/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698