chrome/browser/devtools/devtools_window.h - Issue 137383005: Devtools: UMA for InspectElement loading time was added

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 137383005: Devtools: UMA for InspectElement loading time was added (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Formatting fix Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/devtools/devtools_embedder_message_dispatcher.h ('K') | « chrome/browser/devtools/devtools_embedder_message_dispatcher.cc ('k') | chrome/browser/devtools/devtools_window.cc » ('j') | chrome/browser/devtools/devtools_window.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_window.h

diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h

index b2dfa7f7b06cd3f47495e53d047cad629e1b245f..966a2992713715d7e6379c60f7179fdcea5e2060 100644

--- a/chrome/browser/devtools/devtools_window.h

+++ b/chrome/browser/devtools/devtools_window.h

@@ -298,6 +298,7 @@ class DevToolsWindow : private content::NotificationObserver,

virtual void CloseWindow() OVERRIDE;

virtual void SetContentsInsets(

int left, int top, int right, int bottom) OVERRIDE;

+ virtual void InspectElementLoadingCompleted() OVERRIDE;

virtual void MoveWindow(int x, int y) OVERRIDE;

virtual void SetIsDocked(bool is_docked) OVERRIDE;

virtual void OpenInNewTab(const std::string& url) OVERRIDE;

@@ -385,6 +386,7 @@ class DevToolsWindow : private content::NotificationObserver,

scoped_ptr<DevToolsEmbedderMessageDispatcher> embedder_message_dispatcher_;

base::WeakPtrFactory<DevToolsWindow> weak_factory_;

+ base::TimeTicks inspect_element_start_time_;

DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);

};