Devtools: UMA for InspectElement loading time was added

chrome/browser/devtools/devtools_window.cc

Index: chrome/browser/devtools/devtools_window.cc
diff --git a/chrome/browser/devtools/devtools_window.cc b/chrome/browser/devtools/devtools_window.cc
index ce6f49696d0c26d05325567fad10c66a6297ba3b..9e230fb2540285e7718163b11d7f53fe5188d147 100644
--- a/chrome/browser/devtools/devtools_window.cc
+++ b/chrome/browser/devtools/devtools_window.cc
@@ -9,10 +9,12 @@
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
+#include "base/metrics/histogram.h"
 #include "base/prefs/scoped_user_pref_update.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
+#include "base/time/time.h"
 #include "base/values.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/chrome_notification_types.h"
@@ -467,9 +469,14 @@ void DevToolsWindow::InspectElement(content::RenderViewHost* inspected_rvh,
   scoped_refptr<DevToolsAgentHost> agent(
       DevToolsAgentHost::GetOrCreateFor(inspected_rvh));
   agent->InspectElement(x, y);
+  bool should_measure_time = FindDevToolsWindow(agent.get()) == NULL;
+  base::TimeTicks start_time = base::TimeTicks::Now();
   // TODO(loislo): we should initiate DevTools window opening from within
   // renderer. Otherwise, we still can hit a race condition here.
-  OpenDevToolsWindow(inspected_rvh);
+  DevToolsWindow* window = OpenDevToolsWindow(inspected_rvh);
+  if (should_measure_time) {

[pfeldman, 2014/01/29 13:51:35]

drop {}

[sergeyv, 2014/01/29 14:12:38]

Done.

+    window->inspect_element_start_time_ = start_time;
+  }
 }
 
 // static
@@ -999,6 +1006,14 @@ void DevToolsWindow::SetContentsInsets(
   }
 }
 
+void DevToolsWindow::InspectElementLoadingCompleted() {
+  if (!inspect_element_start_time_.is_null()) {
+    UMA_HISTOGRAM_TIMES("DevTools.InspectElement",
+        base::TimeTicks::Now() - inspect_element_start_time_);
+    inspect_element_start_time_ = base::TimeTicks();
+  }
+}
+
 void DevToolsWindow::MoveWindow(int x, int y) {
   if (!is_docked_) {
     gfx::Rect bounds = browser_->window()->GetBounds();