Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.h

Issue 1373753002: Change CSSToStyleMap functions to take const CSSValue&s (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Review feedback Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp ('k') | third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.h
diff --git a/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.h b/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.h
index 0bf3be963fe4841aa65b2774b74db9c2ef001647..1104fd3ed0df7514acde7bf1386a7517506a7507 100644
--- a/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.h
+++ b/third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.h
@@ -40,33 +40,33 @@ class BorderImageLengthBox;
class CSSToStyleMap {
STATIC_ONLY(CSSToStyleMap);
public:
- static void mapFillAttachment(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillClip(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillComposite(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillBlendMode(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillOrigin(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillImage(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillRepeatX(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillRepeatY(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillSize(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillXPosition(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillYPosition(StyleResolverState&, FillLayer*, CSSValue*);
- static void mapFillMaskSourceType(StyleResolverState&, FillLayer*, CSSValue*);
+ static void mapFillAttachment(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillClip(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillComposite(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillBlendMode(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillOrigin(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillImage(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillRepeatX(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillRepeatY(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillSize(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillXPosition(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillYPosition(StyleResolverState&, FillLayer*, const CSSValue&);
+ static void mapFillMaskSourceType(StyleResolverState&, FillLayer*, const CSSValue&);
- static double mapAnimationDelay(CSSValue*);
- static Timing::PlaybackDirection mapAnimationDirection(CSSValue*);
- static double mapAnimationDuration(CSSValue*);
- static Timing::FillMode mapAnimationFillMode(CSSValue*);
- static double mapAnimationIterationCount(CSSValue*);
- static AtomicString mapAnimationName(CSSValue*);
- static EAnimPlayState mapAnimationPlayState(CSSValue*);
- static CSSTransitionData::TransitionProperty mapAnimationProperty(CSSValue*);
- static PassRefPtr<TimingFunction> mapAnimationTimingFunction(CSSValue*, bool allowStepMiddle = false);
+ static double mapAnimationDelay(const CSSValue&);
+ static Timing::PlaybackDirection mapAnimationDirection(const CSSValue&);
+ static double mapAnimationDuration(const CSSValue&);
+ static Timing::FillMode mapAnimationFillMode(const CSSValue&);
+ static double mapAnimationIterationCount(const CSSValue&);
+ static AtomicString mapAnimationName(const CSSValue&);
+ static EAnimPlayState mapAnimationPlayState(const CSSValue&);
+ static CSSTransitionData::TransitionProperty mapAnimationProperty(const CSSValue&);
+ static PassRefPtr<TimingFunction> mapAnimationTimingFunction(const CSSValue&, bool allowStepMiddle = false);
- static void mapNinePieceImage(StyleResolverState&, CSSPropertyID, CSSValue*, NinePieceImage&);
- static void mapNinePieceImageSlice(StyleResolverState&, CSSValue*, NinePieceImage&);
- static BorderImageLengthBox mapNinePieceImageQuad(StyleResolverState&, CSSValue*);
- static void mapNinePieceImageRepeat(StyleResolverState&, CSSValue*, NinePieceImage&);
+ static void mapNinePieceImage(StyleResolverState&, CSSPropertyID, const CSSValue&, NinePieceImage&);
+ static void mapNinePieceImageSlice(StyleResolverState&, const CSSValue&, NinePieceImage&);
+ static BorderImageLengthBox mapNinePieceImageQuad(StyleResolverState&, const CSSValue&);
+ static void mapNinePieceImageRepeat(StyleResolverState&, const CSSValue&, NinePieceImage&);
};
}
« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/AnimatedStyleBuilder.cpp ('k') | third_party/WebKit/Source/core/css/resolver/CSSToStyleMap.cpp » ('j') | third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698