Move Version Assembly code out of chrome_elf.

Move Version Assembly code out of chrome_elf.

This code is not chrome_elf-specific, rather, chrome_elf
is the only current user of it. Move the manifest building
logic to a more generic location.

BUG=324863
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245307

[Cait (Slow), 2014-01-13 20:53:44]

Hi Gab, here is a first pass at moving the chrome version manifest generation
code out of chrome_elf and into a separate dir. PTAL.

[gab, 2014-01-13 21:43:37]

lgtm w/ comments.

Also, please make me and you the OWNERS of this new directory and remove me from
chrome_elf/OWNERS where I have no other knowledge than the version_assembly :)!

Thanks!
Gab

https://codereview.chromium.org/137373002/diff/1/chrome/app/version_assembly/...
File chrome/app/version_assembly/README (right):

https://codereview.chromium.org/137373002/diff/1/chrome/app/version_assembly/...
chrome/app/version_assembly/README:5: (Currently, chrome_elf.dll is the only
library which uses this framework). This
s/(Currently, chrome_elf.dll is the only library which uses this
framework)/(e.g., chrome_elf.dll)

Shorter and makes this comment more future proof :)

https://codereview.chromium.org/137373002/diff/1/chrome/app/version_assembly/...
chrome/app/version_assembly/README:8: 
Add the following here I'd say:

New DLLs should be added as <file> entries in
"version_assembly_manifest.template".

[gab, 2014-01-13 21:44:56]

https://codereview.chromium.org/137373002/diff/1/chrome/app/version_assembly/...
File chrome/app/version_assembly/chrome_exe_manifest_action.gypi (right):

https://codereview.chromium.org/137373002/diff/1/chrome/app/version_assembly/...
chrome/app/version_assembly/chrome_exe_manifest_action.gypi:6: # declaring a
dependency on chrome_elf.dll. This manifest can then be merged
Generalize this comment to be non-chrome_elf specific.

[Cait (Slow), 2014-01-14 16:11:29]

[+cpu, for chrome/app OWNERS]

cpu: PTAL, thanks!

https://codereview.chromium.org/137373002/diff/1/chrome/app/version_assembly/...
File chrome/app/version_assembly/README (right):

https://codereview.chromium.org/137373002/diff/1/chrome/app/version_assembly/...
chrome/app/version_assembly/README:5: (Currently, chrome_elf.dll is the only
library which uses this framework). This
On 2014/01/13 21:43:37, gab wrote:
> s/(Currently, chrome_elf.dll is the only library which uses this
> framework)/(e.g., chrome_elf.dll)
> 
> Shorter and makes this comment more future proof :)

Done.

https://codereview.chromium.org/137373002/diff/1/chrome/app/version_assembly/...
chrome/app/version_assembly/README:8: 
On 2014/01/13 21:43:37, gab wrote:
> Add the following here I'd say:
> 
> New DLLs should be added as <file> entries in
> "version_assembly_manifest.template".

Done.

[gab, 2014-01-14 16:21:01]

lgtm++, thanks!

[gab, 2014-01-15 20:37:40]

On 2014/01/14 16:21:01, gab wrote:
> lgtm++, thanks!

Oh can you also add me (and yourself if you so desire) to a WATCHLIST for this
new directory, i.e.:
https://code.google.com/p/chromium/codesearch#chromium/src/WATCHLISTS&q=WATCH...

Thanks!
Gab

[cpu_(ooo_6.6-7.5), 2014-01-16 01:56:33]

lgtm

[commit-bot: I haz the power, 2014-01-16 18:52:16]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/caitkp@chromium.org/137373002/290001

[commit-bot: I haz the power, 2014-01-16 20:35:24]

Change committed as 245307