chrome/app/version_assembly/README - Issue 137373002: Move Version Assembly code out of chrome_elf.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/app/version_assembly/README

Issue 137373002: Move Version Assembly code out of chrome_elf. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 Chrome Early Loading Framework (aka ChromeELF)	1 Chrome Version Assembly

2	2

3 chrome_elf.dll is shipped in Chrome's version directory to ease updates,	3 The chrome version assembly makes it possible for load-time dependencies of

4 and is loaded early in chrome.exe's lifetime. This is done by turning the	4 chrome.exe to be shipped in Chrome's version directory to ease updates.

5 version directory into a private assembly which refers to chrome_elf.dll	5 (Currently, chrome_elf.dll is the only library which uses this framework). This
	gab 2014/01/13 21:43:37 s/(Currently, chrome_elf.dll is the only library w s/(Currently, chrome_elf.dll is the only library which uses this framework)/(e.g., chrome_elf.dll) Shorter and makes this comment more future proof :) Cait (Slow) 2014/01/14 16:11:29 Done. Show quoted text On 2014/01/13 21:43:37, gab wrote: > s/(Currently, chrome_elf.dll is the only library which uses this > framework)/(e.g., chrome_elf.dll) > > Shorter and makes this comment more future proof :) Done.
6 (http://msdn.microsoft.com/library/aa374224.aspx).	6 is done by turning the version directory into a private assembly which refers to

	7 any DLLs that chrome.exe needs to know about.

7	8
	gab 2014/01/13 21:43:37 Add the following here I'd say: New DLLs should b Add the following here I'd say: New DLLs should be added as <file> entries in "version_assembly_manifest.template". Cait (Slow) 2014/01/14 16:11:29 Done. Show quoted text On 2014/01/13 21:43:37, gab wrote: > Add the following here I'd say: > > New DLLs should be added as <file> entries in > "version_assembly_manifest.template". Done.
8 In an ideal world, this would be done by embedding an application config in	9 In an ideal world, this would be done by embedding an application config in

9 chrome.exe that would refer to the proper version directory via a	10 chrome.exe that would refer to the proper version directory via a

10 probing\privatePath attribute (http://msdn.microsoft.com/library/aa374182.aspx).	11 probing\privatePath attribute (http://msdn.microsoft.com/library/aa374182.aspx).

11 This would allow us to refer to dlls in the version directory without having to	12 This would allow us to refer to dlls in the version directory without having to

12 make the version directory itself into an assembly. It would also avoid naming	13 make the version directory itself into an assembly. It would also avoid naming

13 conflicts (as the WinSxS dir and GAC both take precedence over private	14 conflicts (as the WinSxS dir and GAC both take precedence over private

14 assemblies when searching for dlls). Unfortunately, the probing\privatePath	15 assemblies when searching for dlls). Unfortunately, the probing\privatePath

15 attribute is only supported for Windows 7 and later.	16 attribute is only supported for Windows 7 and later.

OLD	NEW

« no previous file with comments | « no previous file | chrome/app/version_assembly/chrome_exe_manifest.template » ('j') | chrome/app/version_assembly/chrome_exe_manifest_action.gypi » ('J')