change pixel-serializer to support reencoding existing data

change pixel-serializer to support reencoding existing data

Trying to evolve this interface so it can
- support rich set of backend-encoders (including ones like ETC1 that can cheaply convert to KXT
- allow for encoding images as well as bitmaps (e.g. for picture serialization)
- perhaps replace SkImageEncoder as an API (assuming we create a factory that returns a serializer given a format)

BUG=skia:

Committed: https://skia.googlesource.com/skia/+/13f48dc85aa68a60da66aaf39c93d527d11d1278

[reed1, 2015-09-26 16:28:16]

reed@google.com changed reviewers:
+ msarett@google.com, scroggo@google.com

[reed1, 2015-09-26 16:28:22]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-26 16:28:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373683003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373683003/1

[commit-bot: I haz the power, 2015-09-26 16:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-26 16:33:21]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-09-26 17:15:16]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-26 17:15:29]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373683003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373683003/20001

[commit-bot: I haz the power, 2015-09-26 17:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-26 17:20:17]

Dry run: This issue passed the CQ dry run.

[scroggo, 2015-09-28 13:34:10]

Seems fine to me, once Chromium is fixed.

https://codereview.chromium.org/1373683003/diff/20001/include/core/SkPixelSer...
File include/core/SkPixelSerializer.h (left):

https://codereview.chromium.org/1373683003/diff/20001/include/core/SkPixelSer...
include/core/SkPixelSerializer.h:44: virtual bool onUseEncodedData(const void*
data, size_t len) = 0;
We need to keep this around until we fix the chromium overrides:
https://code.google.com/p/chromium/codesearch#search/&q=useencodeddata&sq=pac...

[reed1, 2015-09-28 14:50:27]

Luckily, chrome's two overrides both return true, which is the same default
behavior as the new method. I think I can just (temporarily) re-add the old
virtual, but not bother to call it, and then remove the overrides from chrome.

[reed1, 2015-09-28 14:54:36]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 14:54:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373683003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373683003/40001

[commit-bot: I haz the power, 2015-09-28 14:55:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 14:55:34]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[reed1, 2015-09-28 15:01:38]

doh, also have changed the param to the other method. Will upload a new patch...

[scroggo, 2015-09-28 15:01:52]

lgtm

[reed1, 2015-09-28 15:45:16]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 15:45:35]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373683003/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373683003/60001

[reed1, 2015-09-28 15:45:45]

reverted to prev param types (pixmap --> info/pixels/rowbytes) to ease the merge
w/ chrome.

[commit-bot: I haz the power, 2015-09-28 15:46:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 15:46:33]

Dry run: Try jobs failed on following builders:
  Build-Ubuntu-Clang-x86_64-Debug-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-Clang-x...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[reed1, 2015-09-28 15:49:11]

The CQ bit was checked by reed@google.com to run a CQ dry run

[commit-bot: I haz the power, 2015-09-28 15:49:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373683003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373683003/80001

[commit-bot: I haz the power, 2015-09-28 15:55:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 15:55:20]

Dry run: This issue passed the CQ dry run.

[reed1, 2015-09-28 15:57:58]

The CQ bit was checked by reed@google.com

[reed1, 2015-09-28 15:57:58]

The patchset sent to the CQ was uploaded after l-g-t-m from scroggo@google.com
Link to the patchset: https://codereview.chromium.org/1373683003/#ps80001
(title: "I hate this warning")

[commit-bot: I haz the power, 2015-09-28 15:58:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1373683003/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1373683003/80001

[commit-bot: I haz the power, 2015-09-28 15:58:57]

Committed patchset #5 (id:80001) as
https://skia.googlesource.com/skia/+/13f48dc85aa68a60da66aaf39c93d527d11d1278

[reed1, 2015-09-28 16:58:22]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1371983003/ by reed@google.com.

The reason for reverting is: Need to somehow get access to encoders in chrome --
link error on the roll since SkImageEncoder is not built as part of chrome..

[scroggo, 2016-03-21 17:59:02]

Description was changed from

==========
change pixel-serializer to support reencoding existing data

Trying to evolve this interface so it can
- support rich set of backend-encoders (including ones like ETC1 that can
cheaply convert to KXT
- allow for encoding images as well as bitmaps (e.g. for picture serialization)
- perhaps replace SkImageEncoder as an API (assuming we create a factory that
returns a serializer given a format)

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/13f48dc85aa68a60da66aaf39c93d527d11d1278
==========

to

==========
change pixel-serializer to support reencoding existing data

Trying to evolve this interface so it can
- support rich set of backend-encoders (including ones like ETC1 that can
cheaply convert to KXT
- allow for encoding images as well as bitmaps (e.g. for picture serialization)
- perhaps replace SkImageEncoder as an API (assuming we create a factory that
returns a serializer given a format)

BUG=skia:

Committed:
https://skia.googlesource.com/skia/+/13f48dc85aa68a60da66aaf39c93d527d11d1278
==========