Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1373423003: Remove MediaController (already diabled by REF) (Closed)

Created:
5 years, 2 months ago by philipj_slow
Modified:
5 years, 2 months ago
Reviewers:
fs
CC:
fs, blink-reviews, blink-reviews-html_chromium.org, blink-reviews-paint_chromium.org, Inactive, dglazkov+blink, dshwang, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, nessy, slimming-paint-reviews_chromium.org, vcarbune.chromium, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove MediaController (already diabled by REF) Intent to Remove: https://groups.google.com/a/chromium.org/d/msg/blink-dev/66zec0JPy-k/-89CRX4VBQAJ It was put behind a disabled RuntimeEnabledFeature in 2014: https://codereview.chromium.org/250553006 BUG=none Committed: https://crrev.com/2f5ffbda7e294845fe59be6fd4aaa74dec5d3cc6 Cr-Commit-Position: refs/heads/master@{#355260}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rewrap comment #

Patch Set 3 : rebase #

Patch Set 4 : update web-platform-tests expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2111 lines) Patch
M third_party/WebKit/LayoutTests/fast/dom/element-attribute-js-null.html View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/dom/element-attribute-js-null-expected.txt View 1 2 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/constructor-length.html View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/fast/js/constructor-length-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/imported/web-platform-tests/html/semantics/embedded-content/media-elements/synchronising-multiple-media-elements/media-controllers/task-source-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
D third_party/WebKit/LayoutTests/media/controls-mute-with-controller.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/controls-mute-with-controller-expected.html View 1 chunk +0 lines, -22 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/controls-restrained-media-controller.html View 1 chunk +0 lines, -20 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/controls-restrained-media-controller-expected.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/controls-timeline-with-controller.html View 1 chunk +0 lines, -43 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/effective-media-volume.html View 1 chunk +0 lines, -19 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller.html View 1 chunk +0 lines, -71 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-effective-playback-rate.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-effective-playback-rate-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-expected.txt View 1 chunk +0 lines, -51 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-media-fragment-uri.html View 1 chunk +0 lines, -33 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-media-fragment-uri-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-media-fragment-uri-initial-playback-position.html View 1 chunk +0 lines, -35 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-media-fragment-uri-initial-playback-position-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-play-then-pause.html View 1 chunk +0 lines, -60 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-play-then-pause-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-playback.html View 1 chunk +0 lines, -56 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-playback-expected.txt View 1 chunk +0 lines, -16 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-playbackrate.html View 1 chunk +0 lines, -58 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-playbackrate-expected.txt View 1 chunk +0 lines, -14 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-time.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-time-clamp.html View 1 chunk +0 lines, -39 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-time-clamp-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-time-constant.html View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-time-constant-expected.txt View 1 chunk +0 lines, -11 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-time-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-timeupdate.html View 1 chunk +0 lines, -28 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-timeupdate-expected.txt View 1 chunk +0 lines, -5 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-unpause.html View 1 chunk +0 lines, -59 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-unpause-expected.txt View 1 chunk +0 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-volume.html View 1 chunk +0 lines, -40 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/media-controller-volume-expected.txt View 1 chunk +0 lines, -15 lines 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-fullscreen.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/media/video-controls-fullscreen.js View 1 chunk +1 line, -2 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-controls-fullscreen-with-controller.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-currentTime-set-with-controller.html View 1 chunk +0 lines, -15 lines 0 comments Download
D third_party/WebKit/LayoutTests/media/video-currentTime-set-with-controller-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/platform/android/webexposed/global-interface-listing-expected.txt View 5 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/element-instance-property-listing-expected.txt View 1 2 4 chunks +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype.html View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/event-target-in-prototype-expected.txt View 1 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt View 1 2 4 chunks +0 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/core.gypi View 1 2 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/events/EventTargetFactory.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLAttributeNames.in View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 9 chunks +1 line, -22 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.cpp View 1 2 26 chunks +18 lines, -197 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.idl View 2 chunks +1 line, -5 lines 0 comments Download
D third_party/WebKit/Source/core/html/MediaController.h View 1 chunk +0 lines, -135 lines 0 comments Download
D third_party/WebKit/Source/core/html/MediaController.cpp View 1 2 1 chunk +0 lines, -618 lines 0 comments Download
D third_party/WebKit/Source/core/html/MediaController.idl View 1 chunk +0 lines, -58 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp View 1 2 5 chunks +6 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/core/html/shadow/MediaControls.cpp View 1 2 5 chunks +6 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373423003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373423003/1
5 years, 2 months ago (2015-10-02 13:47:06 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/121618) mac_chromium_rel_ng on ...
5 years, 2 months ago (2015-10-02 14:50:47 UTC) #4
philipj_slow
PTAL https://codereview.chromium.org/1373423003/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1373423003/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode2710 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2710: // If the media element has a loop ...
5 years, 2 months ago (2015-10-07 10:05:17 UTC) #6
fs
lgtm https://codereview.chromium.org/1373423003/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1373423003/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode2710 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2710: // If the media element has a loop ...
5 years, 2 months ago (2015-10-07 10:17:14 UTC) #7
philipj_slow
https://codereview.chromium.org/1373423003/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp File third_party/WebKit/Source/core/html/HTMLMediaElement.cpp (right): https://codereview.chromium.org/1373423003/diff/1/third_party/WebKit/Source/core/html/HTMLMediaElement.cpp#newcode2710 third_party/WebKit/Source/core/html/HTMLMediaElement.cpp:2710: // If the media element has a loop attribute ...
5 years, 2 months ago (2015-10-07 13:21:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373423003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373423003/20001
5 years, 2 months ago (2015-10-07 13:23:36 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/123470)
5 years, 2 months ago (2015-10-07 14:17:14 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373423003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373423003/60001
5 years, 2 months ago (2015-10-21 07:25:21 UTC) #16
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 2 months ago (2015-10-21 08:27:49 UTC) #17
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 08:28:35 UTC) #18
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/2f5ffbda7e294845fe59be6fd4aaa74dec5d3cc6
Cr-Commit-Position: refs/heads/master@{#355260}

Powered by Google App Engine
This is Rietveld 408576698