Unship MediaController by making it an experimental runtime-enabled feature

Unship MediaController by making it an experimental runtime-enabled feature

Intent to Unship:
https://groups.google.com/a/chromium.org/d/msg/blink-dev/MVcoNSPs1UQ/LIF-fvu2lwoJ

BUG=none

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=172814

[philipj_slow, 2014-04-28 08:42:03]

Jochen, can you review the IDL changes? Aaron, can you review everything else?

Thanks!

[jochen (gone - plz use gerrit), 2014-04-28 09:21:10]

lgtm

[acolwell GONE FROM CHROMIUM, 2014-04-28 15:52:14]

https://codereview.chromium.org/250553006/diff/10001/LayoutTests/virtual/stab...
File
LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt
(right):

https://codereview.chromium.org/250553006/diff/10001/LayoutTests/virtual/stab...
LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt:8:
FAIL MediaController.prototype.__proto__ should be [object Object]. Threw
exception ReferenceError: MediaController is not defined
This doesn't seem right. This is the only FAIL in this file. Why is
MediaController still being tested if it is experimental? Are there no other
experimental EventTargets?

[philipj_slow, 2014-04-28 16:28:18]

https://codereview.chromium.org/250553006/diff/10001/LayoutTests/virtual/stab...
File
LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt
(right):

https://codereview.chromium.org/250553006/diff/10001/LayoutTests/virtual/stab...
LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt:8:
FAIL MediaController.prototype.__proto__ should be [object Object]. Threw
exception ReferenceError: MediaController is not defined
On 2014/04/28 15:52:14, acolwell wrote:
> This doesn't seem right. This is the only FAIL in this file. Why is
> MediaController still being tested if it is experimental? Are there no other
> experimental EventTargets?

There probably are, but event-target-in-prototype.html is simply a list of
interfaces. I could try to rewrite the test to iterate and test all properties
on window, or is there something else I could do?

[acolwell GONE FROM CHROMIUM, 2014-04-28 18:00:11]

On 2014/04/28 16:28:18, philipj wrote:
>
https://codereview.chromium.org/250553006/diff/10001/LayoutTests/virtual/stab...
> File
> LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt
> (right):
> 
>
https://codereview.chromium.org/250553006/diff/10001/LayoutTests/virtual/stab...
>
LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt:8:
> FAIL MediaController.prototype.__proto__ should be [object Object]. Threw
> exception ReferenceError: MediaController is not defined
> On 2014/04/28 15:52:14, acolwell wrote:
> > This doesn't seem right. This is the only FAIL in this file. Why is
> > MediaController still being tested if it is experimental? Are there no other
> > experimental EventTargets?
> 
> There probably are, but event-target-in-prototype.html is simply a list of
> interfaces. I could try to rewrite the test to iterate and test all properties
> on window, or is there something else I could do?

I thought this test might have been auto generated from the IDL, but I see now
it isn't. How about just updating the test to only test the object if it exists?

[philipj_slow, 2014-04-28 20:06:06]

On 2014/04/28 18:00:11, acolwell wrote:
> On 2014/04/28 16:28:18, philipj wrote:
> >
>
https://codereview.chromium.org/250553006/diff/10001/LayoutTests/virtual/stab...
> > File
> > LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt
> > (right):
> > 
> >
>
https://codereview.chromium.org/250553006/diff/10001/LayoutTests/virtual/stab...
> >
>
LayoutTests/virtual/stable/webexposed/event-target-in-prototype-expected.txt:8:
> > FAIL MediaController.prototype.__proto__ should be [object Object]. Threw
> > exception ReferenceError: MediaController is not defined
> > On 2014/04/28 15:52:14, acolwell wrote:
> > > This doesn't seem right. This is the only FAIL in this file. Why is
> > > MediaController still being tested if it is experimental? Are there no
other
> > > experimental EventTargets?
> > 
> > There probably are, but event-target-in-prototype.html is simply a list of
> > interfaces. I could try to rewrite the test to iterate and test all
properties
> > on window, or is there something else I could do?
> 
> I thought this test might have been auto generated from the IDL, but I see now
> it isn't. How about just updating the test to only test the object if it
exists?

Sure, that works for me.

[philipj_slow, 2014-04-28 20:14:59]

There, now updated.

[acolwell GONE FROM CHROMIUM, 2014-04-28 20:31:03]

lgtm

[philipj_slow, 2014-04-28 21:07:01]

The CQ bit was checked by philipj@opera.com

[commit-bot: I haz the power, 2014-04-28 21:07:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/philipj@opera.com/250553006/30001

[commit-bot: I haz the power, 2014-04-28 22:28:56]

Change committed as 172814