Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373293002: Handle inverted rects in SkRRect creation methods (Closed)

Created:
5 years, 2 months ago by robertphillips
Modified:
5 years, 2 months ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Handle inverted rects in SkRRect creation methods An alternative way of addressing this is to alter SkCanvas::drawRoundRect to just reject isEmpty (i.e., un-sorted or truly empty) input rects. BUG=skia:3786 Committed: https://skia.googlesource.com/skia/+/05302f8f24cf0254e1fa713fbfc766387505e511

Patch Set 1 #

Patch Set 2 : Update roundrects GM #

Patch Set 3 : cleanup #

Patch Set 4 : Fixed SK_ARRAY_COUNT error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -42 lines) Patch
M gm/roundrects.cpp View 1 2 10 chunks +35 lines, -17 lines 0 comments Download
M include/core/SkRRect.h View 2 chunks +10 lines, -6 lines 0 comments Download
M src/core/SkRRect.cpp View 10 chunks +25 lines, -19 lines 0 comments Download
M tests/RoundRectTest.cpp View 1 2 3 2 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
robertphillips
5 years, 2 months ago (2015-09-29 17:03:45 UTC) #2
bsalomon
On 2015/09/29 17:03:45, robertphillips wrote: lgtm
5 years, 2 months ago (2015-09-29 17:23:08 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373293002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373293002/40001
5 years, 2 months ago (2015-09-29 17:24:37 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm64-Debug-Android-Trybot/builds/1754) Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on ...
5 years, 2 months ago (2015-09-29 17:25:57 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373293002/60001
5 years, 2 months ago (2015-09-29 17:28:41 UTC) #9
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-29 17:37:08 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373293002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373293002/60001
5 years, 2 months ago (2015-09-29 18:23:29 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-09-29 18:24:13 UTC) #15
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/05302f8f24cf0254e1fa713fbfc766387505e511

Powered by Google App Engine
This is Rietveld 408576698