Fixing endless loop when getting the active profile

chrome/browser/profiles/profile_manager.cc

Index: chrome/browser/profiles/profile_manager.cc
diff --git a/chrome/browser/profiles/profile_manager.cc b/chrome/browser/profiles/profile_manager.cc
index 711740c2d4c745eedcbaff599a5fdc223413460d..9c67e0c38235f0e6391b11429f08f11f1281efd2 100644
--- a/chrome/browser/profiles/profile_manager.cc
+++ b/chrome/browser/profiles/profile_manager.cc
@@ -304,12 +304,15 @@ Profile* ProfileManager::GetActiveUserProfile() {
     return profile_manager->GetActiveUserOrOffTheRecordProfileFromPath(
         profile_manager->user_data_dir());
   chromeos::UserManager* manager = chromeos::UserManager::Get();
-  // Note: The user manager will take care of guest profiles.
-  return manager->GetProfileByUser(manager->GetActiveUser());
-#else
+  const User* user = manager->GetActiveUser();
+  // To avoid an endless loop (crbug.com/334098) we have to additionally check
+  // if the profile of the user was already created.
+  // TODO: This should be cleaned up with the new profile manager.
+  if (user && user->is_profile_created())

[Nikita (slow), 2014/01/14 12:23:15]

So if user profile is not created yet,
GetActiveUserOrOffTheRecordProfileFromPath() will be called.

What does that mean in that scenario i.e. which profile will be used?

+    return manager->GetProfileByUser(manager->GetActiveUser());

[Nikita (slow), 2014/01/14 12:23:15]

nit: pass |user| as an argument.

[Mr4D (OOO till 08-26), 2014/01/14 18:44:37]

Done.

+#endif
   return profile_manager->GetActiveUserOrOffTheRecordProfileFromPath(
       profile_manager->user_data_dir());
-#endif
 }
 
 Profile* ProfileManager::GetProfile(const base::FilePath& profile_dir) {