Fixing endless loop when getting the active profile

chrome/browser/profiles/profile_manager.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profile_manager.h"
 
 #include <set>
 
 #include "base/bind.h"
 #include "base/command_line.h"
@@ skipping 286 matching lines @@
 // static
 Profile* ProfileManager::GetActiveUserProfile() {
   ProfileManager* profile_manager = g_browser_process->profile_manager();
 #if defined(OS_CHROMEOS)
   if (!chromeos::UserManager::IsMultipleProfilesAllowed() ||
       !profile_manager->IsLoggedIn() ||
       !chromeos::UserManager::IsInitialized())
     return profile_manager->GetActiveUserOrOffTheRecordProfileFromPath(
         profile_manager->user_data_dir());
   chromeos::UserManager* manager = chromeos::UserManager::Get();
-  // Note: The user manager will take care of guest profiles.
-  return manager->GetProfileByUser(manager->GetActiveUser());
-#else
+  const User* user = manager->GetActiveUser();
+  // To avoid an endless loop (crbug.com/334098) we have to additionally check
+  // if the profile of the user was already created.
+  // TODO: This should be cleaned up with the new profile manager.
+  if (user && user->is_profile_created())

[Nikita (slow), 2014/01/14 12:23:15]

So if user profile is not created yet,
GetActiveUserOrOffTheRecordProfileFromPath() will be called.

What does that mean in that scenario i.e. which profile will be used?

+    return manager->GetProfileByUser(manager->GetActiveUser());

[Nikita (slow), 2014/01/14 12:23:15]

nit: pass |user| as an argument.

[Mr4D (OOO till 08-26), 2014/01/14 18:44:37]

Done.

+#endif
   return profile_manager->GetActiveUserOrOffTheRecordProfileFromPath(
       profile_manager->user_data_dir());
-#endif
 }
 
 Profile* ProfileManager::GetProfile(const base::FilePath& profile_dir) {
   TRACE_EVENT0("browser", "ProfileManager::GetProfile")
   // If the profile is already loaded (e.g., chrome.exe launched twice), just
   // return it.
   Profile* profile = GetProfileByPath(profile_dir);
   if (NULL != profile)
     return profile;
 
@@ skipping 901 matching lines @@
           last_non_managed_profile_path.BaseName().MaybeAsASCII());
       FinishDeletingProfile(profile_to_delete_path);
     }
   }
 }
 #endif
 
 ProfileManagerWithoutInit::ProfileManagerWithoutInit(
     const base::FilePath& user_data_dir) : ProfileManager(user_data_dir) {
 }