Issue 137323005: Fixing endless loop when getting the active profile

Issue 137323005: Fixing endless loop when getting the active profile (Closed)

Created:
6 years, 11 months ago by Mr4D (OOO till 08-26)

Modified:
6 years, 11 months ago

Reviewers:
Dmitry Polukhin, rpetterson, Nikita (slow)

CC:
chromium-reviews, rginda+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Fixing endless loop when getting the active profile BUG=334098 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245102

Patch Set 2 : Addressed #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -8 lines)			Patch
	M	chrome/browser/chromeos/login/user.h	View	1	2 chunks	+5 lines, -4 lines	0 comments	Download
	M	chrome/browser/profiles/profile_manager.cc	View	1	1 chunk	+8 lines, -4 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Mr4D (OOO till 08-26)

Hello! This endless loop showed up today and I have found the "patch" for it. ...

6 years, 11 months ago (2014-01-14 03:12:27 UTC) #1

Nikita (slow)

https://codereview.chromium.org/137323005/diff/1/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): https://codereview.chromium.org/137323005/diff/1/chrome/browser/profiles/profile_manager.cc#newcode311 chrome/browser/profiles/profile_manager.cc:311: if (user && user->is_profile_created()) So if user profile is ...

6 years, 11 months ago (2014-01-14 12:23:14 UTC) #2

Mr4D (OOO till 08-26)

+rlp, can you please do an owners review? Many thanks! https://codereview.chromium.org/137323005/diff/1/chrome/browser/profiles/profile_manager.cc File chrome/browser/profiles/profile_manager.cc (right): https://codereview.chromium.org/137323005/diff/1/chrome/browser/profiles/profile_manager.cc#newcode312 ...

6 years, 11 months ago (2014-01-14 18:44:36 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/137323005/60001

6 years, 11 months ago (2014-01-14 20:25:43 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/137323005/60001

6 years, 11 months ago (2014-01-14 23:26:37 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/skuhne@chromium.org/137323005/60001

6 years, 11 months ago (2014-01-15 03:06:28 UTC) #9

Message was sent while issue was closed.

Change committed as 245102

Expand Messages | Collapse Messages