Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(252)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1373033004: aura: Defer OutputSurface creation until widget is available (Closed)

Created:
5 years, 2 months ago by no sievers
Modified:
5 years, 2 months ago
Reviewers:
piman
CC:
chromium-reviews, sadrul, Ian Vollick, tfarina, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

aura: Defer OutputSurface creation until widget is available Instead of using setLayerTreeHostClientReady() just defer creation of the OutputSurface. BUG=538713, 538714 TBR=sadrul@chromium.org for renamed method call sites Committed: https://crrev.com/ca8baca4fd8d341bc3ee5ae79724d01275a67aaa Cr-Commit-Position: refs/heads/master@{#352463}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -27 lines) Patch
M content/browser/compositor/browser_compositor_view_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/compositor/reflector_impl_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/software_browser_compositor_output_surface_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/compositor/software_output_device_ozone_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/begin_frame_observer_proxy_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/window_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/compositor.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 5 chunks +18 lines, -5 lines 0 comments Download
M ui/compositor/compositor_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/layer_owner_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/test/test_compositor_host_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_ozone.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/compositor/test/test_compositor_host_x11.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/cocoa/bridged_native_widget.mm View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Issue 1388543004 Patch 1
Issue 1388543004 Patch 20001
Issue 1385043002 Patch 1
Issue 1388543004 Patch 40001

Messages

Total messages: 11 (4 generated)
no sievers
ptal
5 years, 2 months ago (2015-10-02 22:11:14 UTC) #2
piman
lgtm
5 years, 2 months ago (2015-10-05 22:13:04 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373033004/1
5 years, 2 months ago (2015-10-05 22:20:54 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/106858)
5 years, 2 months ago (2015-10-05 22:37:22 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1373033004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1373033004/1
5 years, 2 months ago (2015-10-05 22:46:05 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-05 23:38:14 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 23:39:11 UTC) #11
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ca8baca4fd8d341bc3ee5ae79724d01275a67aaa
Cr-Commit-Position: refs/heads/master@{#352463}

Powered by Google App Engine
This is Rietveld 408576698