Source/core/dom/CharacterData.cpp - Issue 137293005: One more instance of StringBuilder::Append replacing String::Append.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/CharacterData.cpp

Issue 137293005: One more instance of StringBuilder::Append replacing String::Append. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/CharacterData.cpp

diff --git a/Source/core/dom/CharacterData.cpp b/Source/core/dom/CharacterData.cpp

index d0344f255cd4ef2439a1fe46a54527ea67f6a648..2eecf98a3ba54140fd425081db25c8a1663a3824 100644

--- a/Source/core/dom/CharacterData.cpp

+++ b/Source/core/dom/CharacterData.cpp

@@ -70,7 +70,7 @@ String CharacterData::substringData(unsigned offset, unsigned count, ExceptionSt

void CharacterData::parserAppendData(const String& string)

{

unsigned oldLength = m_data.length();

- m_data.append(string);

+ m_data = m_data + string;

ASSERT(!renderer() || isTextNode());

if (isTextNode())

« no previous file with comments | « Source/core/css/MediaList.cpp ('k') | Source/core/fetch/CSSStyleSheetResource.cpp » ('j') | no next file with comments »