Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(135)

Side by Side Diff: Source/core/dom/CharacterData.cpp

Issue 137293005: One more instance of StringBuilder::Append replacing String::Append. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/css/MediaList.cpp ('k') | Source/core/fetch/CSSStyleSheetResource.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved. 4 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 52 matching lines...) Expand 10 before | Expand all | Expand 10 after
63 exceptionState.throwDOMException(IndexSizeError, "The offset " + String: :number(offset) + " is greater than the node's length (" + String::number(length ()) + ")."); 63 exceptionState.throwDOMException(IndexSizeError, "The offset " + String: :number(offset) + " is greater than the node's length (" + String::number(length ()) + ").");
64 return String(); 64 return String();
65 } 65 }
66 66
67 return m_data.substring(offset, count); 67 return m_data.substring(offset, count);
68 } 68 }
69 69
70 void CharacterData::parserAppendData(const String& string) 70 void CharacterData::parserAppendData(const String& string)
71 { 71 {
72 unsigned oldLength = m_data.length(); 72 unsigned oldLength = m_data.length();
73 m_data.append(string); 73 m_data = m_data + string;
74 74
75 ASSERT(!renderer() || isTextNode()); 75 ASSERT(!renderer() || isTextNode());
76 if (isTextNode()) 76 if (isTextNode())
77 toText(this)->updateTextRenderer(oldLength, 0); 77 toText(this)->updateTextRenderer(oldLength, 0);
78 78
79 document().incDOMTreeVersion(); 79 document().incDOMTreeVersion();
80 80
81 if (parentNode()) 81 if (parentNode())
82 parentNode()->childrenChanged(); 82 parentNode()->childrenChanged();
83 } 83 }
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
205 { 205 {
206 return static_cast<int>(length()); 206 return static_cast<int>(length());
207 } 207 }
208 208
209 bool CharacterData::offsetInCharacters() const 209 bool CharacterData::offsetInCharacters() const
210 { 210 {
211 return true; 211 return true;
212 } 212 }
213 213
214 } // namespace WebCore 214 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/MediaList.cpp ('k') | Source/core/fetch/CSSStyleSheetResource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698