Issue 137293005: One more instance of StringBuilder::Append replacing String::Append.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137293005: One more instance of StringBuilder::Append replacing String::Append. (Closed)

Created:
6 years, 11 months ago by maheshkk

Modified:
6 years, 11 months ago

Reviewers:
abarth-chromium

CC:
blink-reviews, kenneth.christiansen, sof, eae+blinkwatch, dglazkov+blink, apavlov+blink_chromium.org, adamk+blink_chromium.org, darktears, Inactive

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

One more instance of StringBuilder::Append replacing String::Append. Also remove instances of String::append where StringBuilder can not be used. Visited top ten sites and no more hits to String::append(WTF::String&). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165133

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -6 lines)			Patch
M	Source/core/css/MediaList.cpp	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	Source/core/dom/CharacterData.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/fetch/CSSStyleSheetResource.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

maheshkk

After this patch we eliminate all calls (as per top ten sites) to String::append(WTF::String&). Please ...

6 years, 11 months ago (2014-01-14 23:08:47 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mahesh.kk@samsung.com/137293005/1

6 years, 11 months ago (2014-01-15 00:02:42 UTC) #3

Message was sent while issue was closed.

Change committed as 165133

Expand Messages | Collapse Messages