Issue 137283007: [Android] Lint pylib/gtest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 137283007: [Android] Lint pylib/gtest. (Closed)

Created:
6 years, 10 months ago by jbudorick

Modified:
6 years, 10 months ago

Reviewers:
craigdh, frankf

CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

[Android] Lint pylib/gtest. BUG=168518 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250668

Patch Set 2 : Address Frank's comment. #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -19 lines)			Patch
M	build/android/pylib/gtest/setup.py	View	1	4 chunks	+8 lines, -9 lines	0 comments	Download
M	build/android/pylib/gtest/test_package.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download
M	build/android/pylib/gtest/test_package_apk.py	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	build/android/pylib/gtest/test_package_exe.py	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

frankf

lgtm w/ nit https://codereview.chromium.org/137283007/diff/1/build/android/pylib/gtest/setup.py File build/android/pylib/gtest/setup.py (right): https://codereview.chromium.org/137283007/diff/1/build/android/pylib/gtest/setup.py#newcode18 build/android/pylib/gtest/setup.py:18: remove blank line

6 years, 10 months ago (2014-02-11 23:41:22 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbudorick@chromium.org/137283007/60001

6 years, 10 months ago (2014-02-12 00:39:10 UTC) #4

Message was sent while issue was closed.

Change committed as 250668

Expand Messages | Collapse Messages

Issue 137283007: [Android] Lint pylib/gtest. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Address Frank's comment. #

Messages