Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Unified Diff: build/android/pylib/gtest/test_package.py

Issue 137283007: [Android] Lint pylib/gtest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address Frank's comment. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | build/android/pylib/gtest/test_package_apk.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/gtest/test_package.py
diff --git a/build/android/pylib/gtest/test_package.py b/build/android/pylib/gtest/test_package.py
index ce07f4fb97101038837ca95d551310a064d0ec55..f82d029758accac420649ea1a4571284cf6eb55c 100644
--- a/build/android/pylib/gtest/test_package.py
+++ b/build/android/pylib/gtest/test_package.py
@@ -3,8 +3,7 @@
# found in the LICENSE file.
"""Base class representing GTest test packages."""
-
-import logging
+# pylint: disable=R0201
class TestPackage(object):
@@ -43,7 +42,7 @@ class TestPackage(object):
"""
raise NotImplementedError('Method must be overriden.')
- def GetGTestReturnCode(self, adb):
+ def GetGTestReturnCode(self, _adb):
return None
def SpawnTestProcess(self, adb):
@@ -65,7 +64,8 @@ class TestPackage(object):
"""
raise NotImplementedError('Method must be overriden.')
- def _ParseGTestListTests(self, raw_list):
+ @staticmethod
+ def _ParseGTestListTests(raw_list):
"""Parses a raw test list as provided by --gtest_list_tests.
Args:
« no previous file with comments | « build/android/pylib/gtest/setup.py ('k') | build/android/pylib/gtest/test_package_apk.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698