Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(115)

Issue 1372823002: No need to recalc style before StyleResolver::computeFont. (Closed)

Created:
5 years, 2 months ago by rune
Modified:
5 years, 2 months ago
Reviewers:
kojii
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

No need to recalc style before StyleResolver::computeFont. StyleResolver::computeFont does not rely on the computed style of any elements in the document tree. The updateLayoutTree call was there to avoid an assert due to an unnecessary composed tree traversal for a parent node. That traversal was removed by [1], so the updateLayoutTree call should no longer be needed. This change gets rid of synchronous style recalcs when FontFaceSet.load() is called. [1] https://codereview.chromium.org/1367743002/ BUG=536625 Committed: https://crrev.com/dc369a994337bd2c92948bf4d27d1549c063d6c2 Cr-Commit-Position: refs/heads/master@{#351025}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/css/invalidation/font-face-load.html View 1 chunk +23 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/invalidation/font-face-load-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/FontFaceSet.cpp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372823002/1
5 years, 2 months ago (2015-09-27 15:41:43 UTC) #2
rune
5 years, 2 months ago (2015-09-27 15:45:09 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-27 16:54:19 UTC) #6
kojii
lgtm, thank you for fixing this in much better way.
5 years, 2 months ago (2015-09-28 01:08:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372823002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372823002/1
5 years, 2 months ago (2015-09-28 05:07:41 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 05:12:34 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 05:13:27 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dc369a994337bd2c92948bf4d27d1549c063d6c2
Cr-Commit-Position: refs/heads/master@{#351025}

Powered by Google App Engine
This is Rietveld 408576698