Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1367743002: Fix assert when resolving font on canvas with dirty shadow distribution (Closed)

Created:
5 years, 2 months ago by Justin Novosad
Modified:
5 years, 2 months ago
Reviewers:
Timothy Loh, rune
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assert when resolving font on canvas with dirty shadow distribution This CL fixes the assert and also avoids unnecessary style computation BUG=535171 R=timloh@chromium.org,rune@opera.com Committed: https://crrev.com/0a340869532dfb0739d87a963905839c24baff21 Cr-Commit-Position: refs/heads/master@{#350646}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
A third_party/WebKit/LayoutTests/fast/canvas/bug535171.html View 1 chunk +11 lines, -0 lines 2 comments Download
A + third_party/WebKit/LayoutTests/fast/canvas/bug535171-expected.txt View 0 chunks +-1 lines, --1 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +1 line, -1 line 1 comment Download

Dependent Patchsets:

Messages

Total messages: 8 (1 generated)
Justin Novosad
PTAL
5 years, 2 months ago (2015-09-23 21:56:48 UTC) #1
rune
lgtm https://codereview.chromium.org/1367743002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/bug535171.html File third_party/WebKit/LayoutTests/fast/canvas/bug535171.html (right): https://codereview.chromium.org/1367743002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/bug535171.html#newcode3 third_party/WebKit/LayoutTests/fast/canvas/bug535171.html:3: //Test passes by not crashing I would have ...
5 years, 2 months ago (2015-09-23 22:55:42 UTC) #2
rune
On 2015/09/23 22:55:42, rune wrote: > That's not correct for canvases in the document tree ...
5 years, 2 months ago (2015-09-23 23:07:06 UTC) #3
Justin Novosad
https://codereview.chromium.org/1367743002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/bug535171.html File third_party/WebKit/LayoutTests/fast/canvas/bug535171.html (right): https://codereview.chromium.org/1367743002/diff/1/third_party/WebKit/LayoutTests/fast/canvas/bug535171.html#newcode3 third_party/WebKit/LayoutTests/fast/canvas/bug535171.html:3: //Test passes by not crashing On 2015/09/23 22:55:41, rune ...
5 years, 2 months ago (2015-09-24 19:39:11 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1367743002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1367743002/1
5 years, 2 months ago (2015-09-24 19:41:47 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-24 20:26:50 UTC) #7
commit-bot: I haz the power
5 years, 2 months ago (2015-09-24 20:27:31 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/0a340869532dfb0739d87a963905839c24baff21
Cr-Commit-Position: refs/heads/master@{#350646}

Powered by Google App Engine
This is Rietveld 408576698