Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(546)

Unified Diff: pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart

Issue 1372673003: Use Element.nameLength where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
diff --git a/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart b/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
index 44dcc2391f2f9913b789dffa7cd572110b0afebe..0891156c34ddf4e5c8b95029a0249dd7b600f963 100644
--- a/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
+++ b/pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart
@@ -33,21 +33,15 @@ class ImplementedComputer {
}
void _addImplementedClass(ClassElement type) {
- String name = type.name;
- if (name != null) {
- int offset = type.nameOffset;
- int length = name.length;
- classes.add(new protocol.ImplementedClass(offset, length));
- }
+ int offset = type.nameOffset;
+ int length = type.nameLength;
+ classes.add(new protocol.ImplementedClass(offset, length));
}
void _addImplementedMember(Element member) {
- String name = member.displayName;
- if (name != null) {
- int offset = member.nameOffset;
- int length = name.length;
- members.add(new protocol.ImplementedMember(offset, length));
- }
+ int offset = member.nameOffset;
+ int length = member.nameLength;
+ members.add(new protocol.ImplementedMember(offset, length));
}
void _addMemberIfImplemented(Element element) {
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698