Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Side by Side Diff: pkg/analysis_server/lib/src/domains/analysis/implemented_dart.dart

Issue 1372673003: Use Element.nameLength where possible. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2015, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library domains.analysis.implemented_dart; 5 library domains.analysis.implemented_dart;
6 6
7 import 'package:analysis_server/src/protocol_server.dart' as protocol; 7 import 'package:analysis_server/src/protocol_server.dart' as protocol;
8 import 'package:analysis_server/src/services/search/hierarchy.dart'; 8 import 'package:analysis_server/src/services/search/hierarchy.dart';
9 import 'package:analysis_server/src/services/search/search_engine.dart'; 9 import 'package:analysis_server/src/services/search/search_engine.dart';
10 import 'package:analyzer/src/generated/element.dart'; 10 import 'package:analyzer/src/generated/element.dart';
(...skipping 15 matching lines...) Expand all
26 if (subtypes.isNotEmpty) { 26 if (subtypes.isNotEmpty) {
27 _addImplementedClass(type); 27 _addImplementedClass(type);
28 } 28 }
29 type.accessors.forEach(_addMemberIfImplemented); 29 type.accessors.forEach(_addMemberIfImplemented);
30 type.fields.forEach(_addMemberIfImplemented); 30 type.fields.forEach(_addMemberIfImplemented);
31 type.methods.forEach(_addMemberIfImplemented); 31 type.methods.forEach(_addMemberIfImplemented);
32 } 32 }
33 } 33 }
34 34
35 void _addImplementedClass(ClassElement type) { 35 void _addImplementedClass(ClassElement type) {
36 String name = type.name; 36 int offset = type.nameOffset;
37 if (name != null) { 37 int length = type.nameLength;
38 int offset = type.nameOffset; 38 classes.add(new protocol.ImplementedClass(offset, length));
39 int length = name.length;
40 classes.add(new protocol.ImplementedClass(offset, length));
41 }
42 } 39 }
43 40
44 void _addImplementedMember(Element member) { 41 void _addImplementedMember(Element member) {
45 String name = member.displayName; 42 int offset = member.nameOffset;
46 if (name != null) { 43 int length = member.nameLength;
47 int offset = member.nameOffset; 44 members.add(new protocol.ImplementedMember(offset, length));
48 int length = name.length;
49 members.add(new protocol.ImplementedMember(offset, length));
50 }
51 } 45 }
52 46
53 void _addMemberIfImplemented(Element element) { 47 void _addMemberIfImplemented(Element element) {
54 if (!element.isSynthetic) { 48 if (!element.isSynthetic) {
55 String name = element.displayName; 49 String name = element.displayName;
56 if (name != null && _hasOverride(name)) { 50 if (name != null && _hasOverride(name)) {
57 _addImplementedMember(element); 51 _addImplementedMember(element);
58 } 52 }
59 } 53 }
60 } 54 }
61 55
62 bool _hasOverride(String name) { 56 bool _hasOverride(String name) {
63 for (ClassElement subtype in subtypes) { 57 for (ClassElement subtype in subtypes) {
64 if (subtype.getMethod(name) != null) { 58 if (subtype.getMethod(name) != null) {
65 return true; 59 return true;
66 } 60 }
67 if (subtype.getField(name) != null) { 61 if (subtype.getField(name) != null) {
68 return true; 62 return true;
69 } 63 }
70 } 64 }
71 return false; 65 return false;
72 } 66 }
73 } 67 }
OLDNEW
« no previous file with comments | « no previous file | pkg/analysis_server/lib/src/domains/analysis/occurrences_dart.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698