Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(99)

Issue 1372413004: Add UA backdrop style. (Closed)

Created:
5 years, 2 months ago by dsinclair
Modified:
5 years, 2 months ago
Reviewers:
esprehn, philipj_slow
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add UA backdrop style. This CL adds a display style to the default ::backdrop. As per https://fullscreen.spec.whatwg.org/#user-agent-level-style-sheet-defaults BUG=240576

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M third_party/WebKit/Source/core/css/html.css View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (1 generated)
dsinclair
PTAL. This seemed unrelated to the fullscreen patch so I pulled it out to its ...
5 years, 2 months ago (2015-09-29 13:31:23 UTC) #2
philipj_slow
lgtm
5 years, 2 months ago (2015-09-29 13:51:58 UTC) #3
dsinclair
This looks like it causes a bunch of test failures. A lot of them are ...
5 years, 2 months ago (2015-09-29 14:32:46 UTC) #4
dsinclair
On 2015/09/29 14:32:46, dsinclair wrote: > Text says backdrop should not be shown but is. ...
5 years, 2 months ago (2015-09-30 20:09:11 UTC) #5
esprehn
What does the spec say? Why !important? I'm not sure it should be forced to ...
5 years, 2 months ago (2015-09-30 20:11:32 UTC) #6
esprehn
What does the spec say? Why !important? I'm not sure it should be forced to ...
5 years, 2 months ago (2015-09-30 20:11:32 UTC) #7
dsinclair
On 2015/09/30 20:11:32, esprehn wrote: > What does the spec say? Why !important? I'm not ...
5 years, 2 months ago (2015-09-30 20:13:07 UTC) #8
philipj_slow
On 2015/09/30 20:13:07, dsinclair wrote: > On 2015/09/30 20:11:32, esprehn wrote: > > What does ...
5 years, 2 months ago (2015-10-01 09:06:19 UTC) #9
esprehn
On 2015/10/01 at 09:06:19, philipj wrote: > On 2015/09/30 20:13:07, dsinclair wrote: > > On ...
5 years, 2 months ago (2015-10-01 09:30:11 UTC) #10
philipj_slow
On 2015/10/01 09:30:11, esprehn wrote: > On 2015/10/01 at 09:06:19, philipj wrote: > > On ...
5 years, 2 months ago (2015-10-01 09:38:08 UTC) #11
philipj_slow
5 years, 2 months ago (2015-10-06 08:38:43 UTC) #12
The spec bug was resolved by removing this rule, so nothing to do in this CL :)

Powered by Google App Engine
This is Rietveld 408576698