Remove deprecated Expect from the libraries.

Remove deprecated Expect from the libraries.

Committed: https://code.google.com/p/dart/source/detail?r=21079

[floitsch, 2013-04-05 23:34:45]

Mostly adding import "package:expect/expect.dart" to the test-files. The
exceptions are:
runtime/vm/dart_api_impl_test.cc
tests/standalone/debugger/debug_lib.dart
tests/standalone/io/file_read_stdio_script.dart
tests/standalone/io/test_runner_test.dart
tools/testing/dart/test_runner.dart

Please have a special look at them.

This CL has the potential to go out of date very fast, so I will try to commit
as soon as possible (once I get an LGTM). Don't hesitate to comment after the
commit. If necessary I will make another CL to address the comments.

[kustermann, 2013-04-06 14:21:10]

lgtm

[Lasse Reichstein Nielsen, 2013-04-08 11:27:49]

LGTM, but remove the Exception's.

https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/deb...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/deb...
tests/standalone/debugger/debug_lib.dart:458: if (errorsDetected) throw new
Exception("Errors detected");
Why use "Exception" and not "Error"?
Or perhaps just the string.

Exceptions are intended for libraries creating domain specific alternative
return values for exceptional cases.
I would expect a unit-test framework to have their own hierarchy of errors that
are neither programming Errors or Exception cases, but something the user code
doesn't even know about, and in the absence of a framework, just throw the
string.

https://codereview.chromium.org/13724021/diff/1/tests/standalone/io/test_runn...
File tests/standalone/io/test_runner_test.dart (right):

https://codereview.chromium.org/13724021/diff/1/tests/standalone/io/test_runn...
tests/standalone/io/test_runner_test.dart:39: throw new Exception("bad
completion count. " +
Remove '+'?

[floitsch, 2013-04-08 12:06:47]

https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/deb...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/deb...
tests/standalone/debugger/debug_lib.dart:458: if (errorsDetected) throw new
Exception("Errors detected");
On 2013/04/08 11:27:49, Lasse Reichstein Nielsen wrote:
> Why use "Exception" and not "Error"?
> Or perhaps just the string.
> 
> Exceptions are intended for libraries creating domain specific alternative
> return values for exceptional cases.
> I would expect a unit-test framework to have their own hierarchy of errors
that
> are neither programming Errors or Exception cases, but something the user code
> doesn't even know about, and in the absence of a framework, just throw the
> string.

I wanted to use the Error class, but Error doesn't allow for a message. So I
switched to Exception instead.
I could fix the Error class to allow for a message.

[floitsch, 2013-04-08 16:06:59]

https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/deb...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/13724021/diff/1/tests/standalone/debugger/deb...
tests/standalone/debugger/debug_lib.dart:458: if (errorsDetected) throw new
Exception("Errors detected");
On 2013/04/08 12:06:47, floitsch wrote:
> On 2013/04/08 11:27:49, Lasse Reichstein Nielsen wrote:
> > Why use "Exception" and not "Error"?
> > Or perhaps just the string.
> > 
> > Exceptions are intended for libraries creating domain specific alternative
> > return values for exceptional cases.
> > I would expect a unit-test framework to have their own hierarchy of errors
> that
> > are neither programming Errors or Exception cases, but something the user
code
> > doesn't even know about, and in the absence of a framework, just throw the
> > string.
> 
> I wanted to use the Error class, but Error doesn't allow for a message. So I
> switched to Exception instead.
> I could fix the Error class to allow for a message.

Done.

https://codereview.chromium.org/13724021/diff/1/tests/standalone/io/test_runn...
File tests/standalone/io/test_runner_test.dart (right):

https://codereview.chromium.org/13724021/diff/1/tests/standalone/io/test_runn...
tests/standalone/io/test_runner_test.dart:39: throw new Exception("bad
completion count. " +
On 2013/04/08 11:27:49, Lasse Reichstein Nielsen wrote:
> Remove '+'?

Done.

[floitsch, 2013-04-08 16:08:46]

Committed patchset #2 manually as r21079 (presubmit successful).

[srdjan, 2013-04-08 16:36:49]

LGTM

It would be good if the co19 tests could be updated ASAP, otherwise it seems
that we have quite a testing gap. (CC-d Peter).