Remove deprecated Expect from the libraries.

tests/standalone/debugger/debug_lib.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // Library used by debugger wire protocol tests (standalone VM debugging).
 
 library DartDebugger;
 
 import "dart:io";
 import "dart:math";
@@ skipping 437 matching lines @@
 
   void close({killDebugee: false}) {
     if (errorsDetected) {
       for (int i = 0; i < errors.length; i++) print(errors[i]);
     }
     if (socket != null) socket.close();
     if (killDebugee) {
       targetProcess.kill();
       print("Target process killed");
     }
-    Expect.isTrue(!errorsDetected);
+    if (errorsDetected) throw new Exception("Errors detected");

[Lasse Reichstein Nielsen, 2013/04/08 11:27:49]

Why use "Exception" and not "Error"?
Or perhaps just the string.

Exceptions are intended for libraries creating domain specific alternative
return values for exceptional cases.
I would expect a unit-test framework to have their own hierarchy of errors that
are neither programming Errors or Exception cases, but something the user code
doesn't even know about, and in the absence of a framework, just throw the
string.

[floitsch, 2013/04/08 12:06:47]

I wanted to use the Error class, but Error doesn't allow for a message. So I
switched to Exception instead.
I could fix the Error class to allow for a message.

[floitsch, 2013/04/08 16:06:59]

Done.

     exit(errors.length);
   }
 }
 
 
 bool RunScript(List script) {
   var options = new Options();
   if (options.arguments.contains("--debuggee")) {
     return false;
   }
@@ skipping 11 matching lines @@
       // is initialized.
       targetOpts.add("--verbose_debug");
       targetOpts.add(options.script);
       targetOpts.add("--debuggee");
       print('args: ${targetOpts.join(" ")}');
 
       Process.start(options.executable, targetOpts).then((Process process) {
         print("Debug target process started");
         process.stdin.close();
         process.exitCode.then((int exitCode) {
-          Expect.equals(0, exitCode);
+          if (exitCode != 0) throw new Exception("bad exit code: $exitCode");
           print("Debug target process exited with exit code $exitCode");
         });
         var debugger =
             new Debugger(process, debugPort, new DebugScript(script));
       });
     },
     onError: (e) {
       if (++retries >= 3) { 
         print('unable to find unused port: $e');
         return -1; 
       } else {
         // Retry with another random port.
         RunScript(script);
       }
     });
   return true;
 }