Making structure for ContentSettings and its corresponding strings.

components/content_settings/core/browser/content_settings_utils.h

Index: components/content_settings/core/browser/content_settings_utils.h
diff --git a/components/content_settings/core/browser/content_settings_utils.h b/components/content_settings/core/browser/content_settings_utils.h
index 2efa0ed4f9e8184afc12678dc10abad414dd400c..bbe2e9ca84edca47c9b24704ef242999996052e1 100644
--- a/components/content_settings/core/browser/content_settings_utils.h
+++ b/components/content_settings/core/browser/content_settings_utils.h
@@ -59,9 +59,15 @@ const char kChromeUIScheme[] = "chrome";
 const char kExtensionScheme[] = "chrome-extension";
 #endif
 
-std::string ContentSettingToString(ContentSetting setting);
-
-ContentSetting ContentSettingFromString(const std::string& name);
+// Converts a ContentSetting to the corresponding content setting string.
+// Returns true if |setting| specifies a valid content setting string, false
+// otherwise.
+bool ContentSettingToString(ContentSetting setting,

[Bernhard Bauer, 2015/10/07 11:38:21]

I think for this method returning the old signature is okay, as there should be
no way to get a ContentSetting with an invalid value, so we should be able to
DCHECK that.

[Deepak, 2015/10/07 13:54:43]

Done.

+                            std::string* setting_string);
+
+// Converts a content setting string to the corresponding ContentSetting.
+// Returns true if |name| specifies a valid content setting, false otherwise.
+bool ContentSettingFromString(const std::string& name, ContentSetting* setting);
 
 // Converts |Value| to |ContentSetting|.
 ContentSetting ValueToContentSetting(const base::Value* value);