Making structure for ContentSettings and its corresponding strings.

components/content_settings/core/browser/content_settings_utils.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_UTILS_H_
 #define COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_UTILS_H_
 
 #include <string>
 #include <utility>
 
@@ skipping 41 matching lines @@
 // These constants are copied from extensions/common/extension_constants.h and
 // content/public/common/url_constants.h to avoid complicated dependencies.
 // TODO(vabr): Get these constants through the ContentSettingsClient.
 const char kChromeDevToolsScheme[] = "chrome-devtools";
 const char kChromeUIScheme[] = "chrome";
 
 #if defined(ENABLE_EXTENSIONS)
 const char kExtensionScheme[] = "chrome-extension";
 #endif
 
-std::string ContentSettingToString(ContentSetting setting);
+// Converts a ContentSetting to the corresponding content setting string.
+// Returns true if |setting| specifies a valid content setting string, false
+// otherwise.
+bool ContentSettingToString(ContentSetting setting,

[Bernhard Bauer, 2015/10/07 11:38:21]

I think for this method returning the old signature is okay, as there should be
no way to get a ContentSetting with an invalid value, so we should be able to
DCHECK that.

[Deepak, 2015/10/07 13:54:43]

Done.

+                            std::string* setting_string);
 
-ContentSetting ContentSettingFromString(const std::string& name);
+// Converts a content setting string to the corresponding ContentSetting.
+// Returns true if |name| specifies a valid content setting, false otherwise.
+bool ContentSettingFromString(const std::string& name, ContentSetting* setting);
 
 // Converts |Value| to |ContentSetting|.
 ContentSetting ValueToContentSetting(const base::Value* value);
 
 // Converts a |Value| to a |ContentSetting|. Returns true if |value| encodes
 // a valid content setting, false otherwise. Note that |CONTENT_SETTING_DEFAULT|
 // is encoded as a NULL value, so it is not allowed as an integer value.
 bool ParseContentSettingValue(const base::Value* value,
                               ContentSetting* setting);
 
@@ skipping 26 matching lines @@
     ContentSettingsPattern* secondary_pattern);
 
 // Populates |rules| with content setting rules for content types that are
 // handled by the renderer.
 void GetRendererContentSettingRules(const HostContentSettingsMap* map,
                                     RendererContentSettingRules* rules);
 
 }  // namespace content_settings
 
 #endif  // COMPONENTS_CONTENT_SETTINGS_CORE_BROWSER_CONTENT_SETTINGS_UTILS_H_