Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 137233019: Revert of Start EmbeddedWorker during registration - take 2 (Closed)

Created:
6 years, 10 months ago by alph
Modified:
6 years, 10 months ago
Reviewers:
kinuko, alecflett
CC:
chromium-reviews, tzik, jam, nhiroki, joi+watch-content_chromium.org, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Revert of Start EmbeddedWorker during registration - take 2 (https://codereview.chromium.org/140743012/) Reason for revert: Makes virtual/serviceworker/http/tests/serviceworker/registration.html crash. See http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux/builds/26615 Original issue's description: > Start EmbeddedWorker during registration - take 2 > > This adds the starting of the server worker to the registration > job pipeline. Eventually this will also dispatch the 'install' > event. > > A second version of this, based on kinuko's work > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249544 TBR=kinuko@chromium.org,alecflett@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249674

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -318 lines) Patch
M content/browser/service_worker/embedded_worker_registry.h View 2 chunks +1 line, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 1 chunk +0 lines, -5 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 2 chunks +1 line, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 3 chunks +3 lines, -8 lines 0 comments Download
M content/browser/service_worker/service_worker_context_unittest.cc View 9 chunks +4 lines, -23 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_dispatcher_host_unittest.cc View 9 chunks +25 lines, -38 lines 0 comments Download
M content/browser/service_worker/service_worker_job_coordinator.h View 3 chunks +1 line, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_job_coordinator.cc View 4 chunks +5 lines, -21 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 26 chunks +59 lines, -103 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 4 chunks +3 lines, -18 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 7 chunks +7 lines, -57 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_version.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
alph
Created Revert of Start EmbeddedWorker during registration - take 2
6 years, 10 months ago (2014-02-07 11:44:35 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/alph@chromium.org/137233019/1
6 years, 10 months ago (2014-02-07 11:44:54 UTC) #2
commit-bot: I haz the power
Change committed as 249674
6 years, 10 months ago (2014-02-07 11:45:13 UTC) #3
kinuko
6 years, 10 months ago (2014-02-07 11:51:27 UTC) #4
Message was sent while issue was closed.
Whoa, didn't really remember we had a layouttests for SW... thanks.

Powered by Google App Engine
This is Rietveld 408576698