Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1251)

Unified Diff: content/browser/service_worker/service_worker_job_coordinator.cc

Issue 137233019: Revert of Start EmbeddedWorker during registration - take 2 (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_job_coordinator.cc
diff --git a/content/browser/service_worker/service_worker_job_coordinator.cc b/content/browser/service_worker/service_worker_job_coordinator.cc
index f72187e1bdfd2520816a660e6f3020f706910321..58d7e442a585155ce22dd3cd1daa2673958ea6ab 100644
--- a/content/browser/service_worker/service_worker_job_coordinator.cc
+++ b/content/browser/service_worker/service_worker_job_coordinator.cc
@@ -5,7 +5,6 @@
#include "content/browser/service_worker/service_worker_job_coordinator.h"
#include "base/stl_util.h"
-#include "content/browser/service_worker/embedded_worker_registry.h"
#include "content/browser/service_worker/service_worker_registration.h"
namespace content {
@@ -13,14 +12,11 @@
ServiceWorkerJobCoordinator::JobQueue::JobQueue() {}
ServiceWorkerJobCoordinator::JobQueue::~JobQueue() {
- DCHECK(jobs_.empty()) << "Destroying JobQueue with " << jobs_.size()
- << " unfinished jobs";
STLDeleteElements(&jobs_);
}
void ServiceWorkerJobCoordinator::JobQueue::Push(
scoped_ptr<ServiceWorkerRegisterJob> job,
- int source_process_id,
const ServiceWorkerRegisterJob::RegistrationCallback& callback) {
if (jobs_.empty()) {
job->Start();
@@ -28,10 +24,9 @@
} else if (!job->Equals(jobs_.back())) {
jobs_.push_back(job.release());
}
- // Note we are releasing 'job' here.
DCHECK(!jobs_.empty());
- jobs_.back()->AddCallback(callback, source_process_id);
+ jobs_.back()->AddCallback(callback);
}
void ServiceWorkerJobCoordinator::JobQueue::Pop(ServiceWorkerRegisterJob* job) {
@@ -43,47 +38,36 @@
}
ServiceWorkerJobCoordinator::ServiceWorkerJobCoordinator(
- ServiceWorkerStorage* storage,
- EmbeddedWorkerRegistry* worker_registry)
- : storage_(storage),
- worker_registry_(worker_registry),
- weak_factory_(this) {}
+ ServiceWorkerStorage* storage)
+ : storage_(storage), weak_factory_(this) {}
-ServiceWorkerJobCoordinator::~ServiceWorkerJobCoordinator() {
- DCHECK(jobs_.empty()) << "Destroying ServiceWorkerJobCoordinator with "
- << jobs_.size() << " job queues";
-}
+ServiceWorkerJobCoordinator::~ServiceWorkerJobCoordinator() {}
void ServiceWorkerJobCoordinator::Register(
const GURL& pattern,
const GURL& script_url,
- int source_process_id,
const ServiceWorkerRegisterJob::RegistrationCallback& callback) {
scoped_ptr<ServiceWorkerRegisterJob> job = make_scoped_ptr(
new ServiceWorkerRegisterJob(storage_,
- worker_registry_,
this,
pattern,
script_url,
ServiceWorkerRegisterJob::REGISTER));
- jobs_[pattern].Push(job.Pass(), source_process_id, callback);
+ jobs_[pattern].Push(job.Pass(), callback);
}
void ServiceWorkerJobCoordinator::Unregister(
const GURL& pattern,
- int source_process_id,
const ServiceWorkerRegisterJob::UnregistrationCallback& callback) {
scoped_ptr<ServiceWorkerRegisterJob> job = make_scoped_ptr(
new ServiceWorkerRegisterJob(storage_,
- worker_registry_,
this,
pattern,
GURL(),
ServiceWorkerRegisterJob::UNREGISTER));
jobs_[pattern]
.Push(job.Pass(),
- source_process_id,
base::Bind(&ServiceWorkerJobCoordinator::UnregisterComplete,
weak_factory_.GetWeakPtr(),
callback));

Powered by Google App Engine
This is Rietveld 408576698