Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(981)

Issue 1372313003: Oilpan: Add TRACE_DISABLED_BY_DEFAULT to trace counters in oilpan (Closed)

Created:
5 years, 2 months ago by haraken
Modified:
5 years, 2 months ago
CC:
blink-reviews, kouhei+heap_chromium.org, oilpan-reviews, Mads Ager (chromium)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: Add TRACE_DISABLED_BY_DEFAULT to trace counters in oilpan Those trace counters are messing up the top of the UI of about:tracing. Since the counters are interesting to only oilpan developers, this CL disables the counters (except for four important counters). See https://github.com/catapult-project/catapult/issues/1528 and https://groups.google.com/a/chromium.org/forum/#!topic/oilpan-reviews/AGegKLIIou8 for more details. Committed: https://crrev.com/9da9d03f47fb41dcf88931dfed8dac08d90778b2 Cr-Commit-Position: refs/heads/master@{#354184}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M third_party/WebKit/Source/platform/heap/Heap.cpp View 1 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
haraken
PTAL
5 years, 2 months ago (2015-09-29 12:25:53 UTC) #2
petrcermak
LGTM. nduca: Could you please double-check that this approach is in line with the rest ...
5 years, 2 months ago (2015-09-29 12:34:48 UTC) #4
nduca
lgtm thanks haraken!
5 years, 2 months ago (2015-09-29 12:36:18 UTC) #5
haraken
> One nit in the patch description: s/counters is/counters are/ > > I think it ...
5 years, 2 months ago (2015-09-29 12:37:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372313003/1
5 years, 2 months ago (2015-09-29 12:40:09 UTC) #8
sof
lgtm
5 years, 2 months ago (2015-09-29 12:43:45 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/110186)
5 years, 2 months ago (2015-09-29 14:02:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372313003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372313003/1
5 years, 2 months ago (2015-10-06 06:16:12 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/77879) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 2 months ago (2015-10-06 06:17:30 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372313003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372313003/20001
5 years, 2 months ago (2015-10-14 22:53:59 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-15 01:08:25 UTC) #20
commit-bot: I haz the power
5 years, 2 months ago (2015-10-15 01:10:09 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/9da9d03f47fb41dcf88931dfed8dac08d90778b2
Cr-Commit-Position: refs/heads/master@{#354184}

Powered by Google App Engine
This is Rietveld 408576698