Remove the ENABLE_TEXT_AUTOSIZING compile-time flag.

Remove the ENABLE_TEXT_AUTOSIZING compile-time flag.

This flag is enabled on all of Chromium, and has a run-time flag which
allows the feature to be disabled (currently disabled by default for
all platforms but Android).

BUG=

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=147804

[abarth-chromium, 2013-04-05 17:33:02]

lgtm

[johnme, 2013-04-05 17:51:23]

Code change looks fine.

This'll make it harder to identify all the places touched by Text Autosizing
(for example new people working on TA might currently look for the compile flag
to see where it integrates), but that's probably fine.

There are going to be Chromium platforms that never turn this on though (e.g.
Chrome desktop and Opera both on desktop and mobile). Is it our policy that
features used by only some platforms should be compiled in anyway and toggled at
runtime?

See also comment below about text zoom.

https://codereview.chromium.org/13723004/diff/1/Source/WebCore/page/animation...
File Source/WebCore/page/animation/CSSPropertyAnimation.cpp (left):

https://codereview.chromium.org/13723004/diff/1/Source/WebCore/page/animation...
Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1120: // FIXME: Find some
way to assert that text zoom isn't activated when Text Autosizing is compiled
in.
This one is interesting. Currently Chrome doesn't use text zoom (like you get in
Firefox if you enable View -> Zoom -> Zoom Text Only), as the Chrome UI only
exposes full page zoom.

But it still seems a shame to leave it in a broken state (as opposed to now,
where it works if ENABLE_TEXT_AUTOSIZING==0, though that's never the case in
Chromium builds).

[abarth-chromium, 2013-04-05 17:53:27]

On 2013/04/05 17:51:23, johnme wrote:
> There are going to be Chromium platforms that never turn this on though (e.g.
> Chrome desktop and Opera both on desktop and mobile). Is it our policy that
> features used by only some platforms should be compiled in anyway and toggled
at
> runtime?

Our approach is to use runtime flags.  In cases where there's a big impact on
binary size, we might use compile-time flags as well.

>
https://codereview.chromium.org/13723004/diff/1/Source/WebCore/page/animation...
> File Source/WebCore/page/animation/CSSPropertyAnimation.cpp (left):
> 
>
https://codereview.chromium.org/13723004/diff/1/Source/WebCore/page/animation...
> Source/WebCore/page/animation/CSSPropertyAnimation.cpp:1120: // FIXME: Find
some
> way to assert that text zoom isn't activated when Text Autosizing is compiled
> in.
> This one is interesting. Currently Chrome doesn't use text zoom (like you get
in
> Firefox if you enable View -> Zoom -> Zoom Text Only), as the Chrome UI only
> exposes full page zoom.
> 
> But it still seems a shame to leave it in a broken state (as opposed to now,
> where it works if ENABLE_TEXT_AUTOSIZING==0, though that's never the case in
> Chromium builds).

Peter, would you be willing to file a bug about this issue and reference it in
the code?

[johnme, 2013-04-08 09:47:01]

On 2013/04/05 17:53:27, abarth wrote:
> Peter, would you be willing to file a bug about this issue and reference it in
> the code?

Cool, LGTM with this. Thanks for the cleanup Peter!

[Peter Beverloo, 2013-04-08 13:04:40]

I added a note mentioning a bug.  Thanks guys!

[Peter Beverloo, 2013-04-08 13:09:16]

Committed patchset #2 manually as r147804 (presubmit successful).