ash/wm/overview/window_selector_unittest.cc - Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/overview/window_selector_unittest.cc

Issue 1372253002: gfx: Make conversions from gfx::Point to PointF explicit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: pointfconvert-gfx: . Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/wm/immersive_fullscreen_controller_unittest.cc ('k') | ash/wm/panels/panel_layout_manager_unittest.cc » ('j') | cc/layers/delegated_renderer_layer_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/wm/overview/window_selector_unittest.cc

diff --git a/ash/wm/overview/window_selector_unittest.cc b/ash/wm/overview/window_selector_unittest.cc

index e9374261211959a28fde4f5fcb240cb6731cf052..42bb47f3142971d6f6b6894d7929f70256dba286 100644

--- a/ash/wm/overview/window_selector_unittest.cc

+++ b/ash/wm/overview/window_selector_unittest.cc

@@ -717,7 +717,8 @@ TEST_F(WindowSelectorTest, WindowDoesNotReceiveEvents) {

aura::Window* root_window = Shell::GetPrimaryRootWindow();

scoped_ptr<aura::Window> window(CreateWindow(window_bounds));

- gfx::Point point1(window_bounds.x() + 10, window_bounds.y() + 10);

+ auto point1 =

+ gfx::PointF(window_bounds.origin()) + gfx::Vector2dF(10.f, 10.f);

ui::MouseEvent event1(ui::ET_MOUSE_PRESSED, point1, point1,

ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE);

@@ -734,7 +735,7 @@ TEST_F(WindowSelectorTest, WindowDoesNotReceiveEvents) {

// The bounds have changed, take that into account.

gfx::RectF bounds = GetTransformedBoundsInRootWindow(window.get());

- gfx::Point point2(bounds.x() + 10, bounds.y() + 10);

+ gfx::PointF point2(bounds.x() + 10.f, bounds.y() + 10.f);

ui::MouseEvent event2(ui::ET_MOUSE_PRESSED, point2, point2,

ui::EventTimeForNow(), ui::EF_NONE, ui::EF_NONE);