Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Issue 1372213003: Revert of Small fix for URLRequestJobs when entering suspending mode. (Closed)

Created:
5 years, 2 months ago by mmenke
Modified:
5 years, 2 months ago
Reviewers:
davidben
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Small fix for URLRequestJobs when entering suspending mode. (patchset #3 id:40001 of https://codereview.chromium.org/1366203004/ ) Reason for revert: Seeing odd failures that make no sense on android bots that may somehow be due to this CL...Trying a revert. :( Original issue's description: > Small fix for URLRequestJobs when entering suspending mode. > > When entering suspend mode, there was a window of time between > when the request was canceled, and when the NetworkDelegate was > informed it was canceled. This didn't exist for other cancellation > paths, and if an embedder invoked certain callbacks in this period, > thinking the request was still live, crashes could result. > > BUG=289715 > > Committed: https://crrev.com/05608da225e05b4a20da3f4ca0cb9a5276fcf3d6 > Cr-Commit-Position: refs/heads/master@{#350938} TBR=davidben@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=289715 Committed: https://crrev.com/638a51dd867573876db6b02edd93367c2e51463a Cr-Commit-Position: refs/heads/master@{#351170}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -50 lines) Patch
M net/url_request/url_request_job.cc View 1 chunk +1 line, -12 lines 0 comments Download
M net/url_request/url_request_unittest.cc View 3 chunks +0 lines, -38 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
mmenke
Created Revert of Small fix for URLRequestJobs when entering suspending mode.
5 years, 2 months ago (2015-09-28 22:07:33 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372213003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372213003/1
5 years, 2 months ago (2015-09-28 22:08:23 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 22:11:05 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 22:12:04 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/638a51dd867573876db6b02edd93367c2e51463a
Cr-Commit-Position: refs/heads/master@{#351170}

Powered by Google App Engine
This is Rietveld 408576698