Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Unified Diff: net/url_request/url_request_job.cc

Issue 1372213003: Revert of Small fix for URLRequestJobs when entering suspending mode. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request_job.cc
diff --git a/net/url_request/url_request_job.cc b/net/url_request/url_request_job.cc
index 5adda9ae05a46e6ea8048720666092ed531d0483..732c9d2da3a63a7374ea742a4b42575aae50ed1a 100644
--- a/net/url_request/url_request_job.cc
+++ b/net/url_request/url_request_job.cc
@@ -279,18 +279,7 @@
}
void URLRequestJob::OnSuspend() {
- // Most errors generated by the Job come as the result of the one current
- // operation the job is waiting on returning an error. This event is unusual
- // in that the Job may have another operation ongoing, or the Job may be idle
- // and waiting on the next call.
- //
- // Need to cancel through the request to make sure everything is notified
- // of the failure (Particularly that the NetworkDelegate, which the Job may be
- // waiting on, is notified synchronously) and torn down correctly.
- //
- // TODO(mmenke): This should probably fail the request with
- // NETWORK_IO_SUSPENDED instead.
- request_->Cancel();
+ Kill();
}
void URLRequestJob::NotifyURLRequestDestroyed() {
« no previous file with comments | « no previous file | net/url_request/url_request_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698