Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(446)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1372103003: Make SkPath fFirstDirection atomic to fix tsan. (Closed)

Created:
5 years, 2 months ago by herb_g
Modified:
5 years, 2 months ago
Reviewers:
mtklein, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkPath fFirstDirection atomic to fix tsan. There is no API change. TBR=reed@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/9f4dbca3290cfaca7dd17b71eb6b5b3a0ba5323e

Patch Set 1 #

Patch Set 2 : WS fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -14 lines) Patch
M include/core/SkPath.h View 1 1 chunk +6 lines, -6 lines 0 comments Download
M src/core/SkPath.cpp View 6 chunks +13 lines, -8 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
herb_g
I need to test on tsan still...
5 years, 2 months ago (2015-09-28 16:21:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372103003/1
5 years, 2 months ago (2015-09-28 16:22:46 UTC) #4
mtklein
lgtm
5 years, 2 months ago (2015-09-28 16:24:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-28 16:28:51 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1372103003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1372103003/20001
5 years, 2 months ago (2015-09-28 17:59:39 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 18:05:51 UTC) #11
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/9f4dbca3290cfaca7dd17b71eb6b5b3a0ba5323e

Powered by Google App Engine
This is Rietveld 408576698