Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: include/core/SkPath.h

Issue 1372103003: Make SkPath fFirstDirection atomic to fix tsan. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: WS fix Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/core/SkPath.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/core/SkPath.h
diff --git a/include/core/SkPath.h b/include/core/SkPath.h
index caf4cfe5ecc9aa0e4e189c96153ea3c8d0f4ff54..d3673b6d5d35504aff815f9dcb58b06582545a69 100644
--- a/include/core/SkPath.h
+++ b/include/core/SkPath.h
@@ -938,13 +938,13 @@ private:
kCurrent_Version = 1
};
- SkAutoTUnref<SkPathRef> fPathRef;
+ SkAutoTUnref<SkPathRef> fPathRef;
- int fLastMoveToIndex;
- uint8_t fFillType;
- mutable uint8_t fConvexity;
- mutable uint8_t fFirstDirection; // SkPathPriv::FirstDirection
- mutable SkBool8 fIsVolatile;
+ int fLastMoveToIndex;
+ uint8_t fFillType;
+ mutable uint8_t fConvexity;
+ mutable SkAtomic<uint8_t> fFirstDirection; // SkPathPriv::FirstDirection
+ mutable SkBool8 fIsVolatile;
/** Resets all fields other than fPathRef to their initial 'empty' values.
* Assumes the caller has already emptied fPathRef.
« no previous file with comments | « no previous file | src/core/SkPath.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698