Issue 1372083002: Subzero. Eliminates the use of Variable64On32 as operands in ARM.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1372083002: Subzero. Eliminates the use of Variable64On32 as operands in ARM. (Closed)

Created:
5 years, 2 months ago by John

Modified:
5 years, 2 months ago

Reviewers:
stichnot1, Karl, sehr

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero. Eliminates the use of Variable64On32 as operands in ARM. This is in preparation for adding atomic support to the ARM backend. Moreover, the code is becoming increasingly complicated due to the use of Variable64On32 as instruction operands. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e0b829f8d2ff3185a885349c37b50144c2191c9a

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -66 lines)			Patch
M	src/IceInstARM32.h	View	1	1 chunk	+8 lines, -10 lines	0 comments	Download
M	src/IceInstARM32.cpp	View	1	4 chunks	+42 lines, -28 lines	0 comments	Download
M	src/IceTargetLoweringARM32.h	View	1	1 chunk	+18 lines, -4 lines	0 comments	Download
M	src/IceTargetLoweringARM32.cpp	View	1	5 chunks	+15 lines, -23 lines	0 comments	Download
M	tests_lit/llvm2ice_tests/fp.convert.ll	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 6 (2 generated)

John

5 years, 2 months ago (2015-09-28 16:50:53 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
e0b829f8d2ff3185a885349c37b50144c2191c9a (tree was closed).