Chromium Code Reviews

Issue 1372083002: Subzero. Eliminates the use of Variable64On32 as operands in ARM. (Closed)

Created:
5 years, 2 months ago by John
Modified:
5 years, 2 months ago
Reviewers:
stichnot1, Karl, sehr
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Subzero. Eliminates the use of Variable64On32 as operands in ARM. This is in preparation for adding atomic support to the ARM backend. Moreover, the code is becoming increasingly complicated due to the use of Variable64On32 as instruction operands. BUG= https://code.google.com/p/nativeclient/issues/detail?id=4076 R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=e0b829f8d2ff3185a885349c37b50144c2191c9a

Patch Set 1 #

Patch Set 2 : Removes Variable64On32 Operands. #

Unified diffs Side-by-side diffs Stats (+84 lines, -66 lines)
M src/IceInstARM32.h View 1 chunk +8 lines, -10 lines 0 comments
M src/IceInstARM32.cpp View 4 chunks +42 lines, -28 lines 0 comments
M src/IceTargetLoweringARM32.h View 1 chunk +18 lines, -4 lines 0 comments
M src/IceTargetLoweringARM32.cpp View 5 chunks +15 lines, -23 lines 0 comments
M tests_lit/llvm2ice_tests/fp.convert.ll View 1 chunk +1 line, -1 line 0 comments

Messages

Total messages: 6 (2 generated)
John
5 years, 2 months ago (2015-09-28 15:44:29 UTC) #2
John
5 years, 2 months ago (2015-09-28 15:45:14 UTC) #4
Karl
lgtm
5 years, 2 months ago (2015-09-28 16:50:02 UTC) #5
John
5 years, 2 months ago (2015-09-28 16:50:53 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
e0b829f8d2ff3185a885349c37b50144c2191c9a (tree was closed).

Powered by Google App Engine